fix nolint directives which aren't guarding anything significant

scope condition one for now

Author: TheFox0x7

services/gitdiff/gitdiff.go

@@ -1356,7 +1356,7 @@ func SyncUserSpecificDiff(ctx context.Context, userID int64, pull *issues_model.
 	// But as that does not work for all potential errors, we simply mark all files as unchanged and drop the error which always works, even if not as good as possible
 	if err != nil {
 		log.Error("Could not get changed files between %s and %s for pull request %d in repo with path %s. Assuming no changes. Error: %w", review.CommitSHA, latestCommit, pull.Index, gitRepo.Path, err)
-		err = nil //nolint
+		err = nil //nolint:ineffassign,wastedassign
 	}
 
 	filesChangedSinceLastDiff := make(map[string]pull_model.ViewedState)

services/migrations/migrate.go

@@ -78,7 +78,7 @@ func IsMigrateURLAllowed(remoteURL string, doer *user_model.User) error {
 	hostName, _, err := net.SplitHostPort(u.Host)
 	if err != nil {
 		// u.Host can be "host" or "host:port"
-		err = nil //nolint
+		err = nil //nolint:ineffassign,wastedassign
 		hostName = u.Host
 	}
 

services/repository/files/file_test.go

@@ -10,9 +10,9 @@ import (
 )
 
 func TestCleanUploadFileName(t *testing.T) {
-	assert.Equal(t, "", CleanGitTreePath(""))  //nolint
-	assert.Equal(t, "", CleanGitTreePath(".")) //nolint
+	assert.Empty(t, CleanGitTreePath(""))
+	assert.Empty(t, CleanGitTreePath("."))
 	assert.Equal(t, "a/b", CleanGitTreePath("a/b"))
-	assert.Equal(t, "", CleanGitTreePath(".git/b")) //nolint
-	assert.Equal(t, "", CleanGitTreePath("a/.git")) //nolint
+	assert.Empty(t, CleanGitTreePath(".git/b"))
+	assert.Empty(t, CleanGitTreePath("a/.git"))
 }

services/user/update.go

@@ -137,7 +137,7 @@ func UpdateUser(ctx context.Context, u *user_model.User, opts *UpdateOptions) er
 		} else if !user_model.IsLastAdminUser(ctx, u) /* not the last admin */ {
 			u.IsAdmin = opts.IsAdmin.Value().FieldValue // it's safe to change it from false to true (not the last admin)
 			cols = append(cols, "is_admin")
-		} else /* IsAdmin=false but this is the last admin user */ { //nolint
+		} else /* IsAdmin=false but this is the last admin user */ { //nolint:gocritic // could flatten the condition, no idea how to flatten comments at the moment
 			if !opts.IsAdmin.Value().FromSync {
 				return user_model.ErrDeleteLastAdminUser{UID: u.ID}
 			}