fix test

Author: wxiaoguang

models/migrations/base/tests.go

@@ -19,6 +19,7 @@ import (
 
 	"github.com/stretchr/testify/require"
 	"xorm.io/xorm"
+	"xorm.io/xorm/schemas"
 )
 
 // FIXME: this file shouldn't be in a normal package, it should only be compiled for tests
@@ -88,6 +89,16 @@ func PrepareTestEnv(t *testing.T, skip int, syncModels ...any) (*xorm.Engine, fu
 	return x, deferFn
 }
 
+func LoadTableSchemasMap(t *testing.T, x *xorm.Engine) map[string]*schemas.Table {
+	tables, err := x.DBMetas()
+	require.NoError(t, err)
+	tableMap := make(map[string]*schemas.Table)
+	for _, table := range tables {
+		tableMap[table.Name] = table
+	}
+	return tableMap
+}
+
 func MainTest(m *testing.M) {
 	testlogger.Init()
 

models/migrations/v1_25/v321_test.go

@@ -11,7 +11,6 @@ import (
 	"code.gitea.io/gitea/modules/timeutil"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func Test_UseLongTextInSomeColumnsAndFixBugs(t *testing.T) {
@@ -49,21 +48,16 @@ func Test_UseLongTextInSomeColumnsAndFixBugs(t *testing.T) {
 
 	assert.NoError(t, UseLongTextInSomeColumnsAndFixBugs(x))
 
-	table, err := x.TableInfo(new(ReviewState))
-	require.NoError(t, err)
+	tables := base.LoadTableSchemasMap(t, x)
+	table := tables["review_state"]
 	column := table.GetColumn("updated_files")
-	require.NotNil(t, column)
 	assert.Equal(t, "LONGTEXT", column.SQLType.Name)
 
-	table, err = x.TableInfo(new(PackageProperty))
-	require.NoError(t, err)
+	table = tables["package_property"]
 	column = table.GetColumn("value")
-	require.NotNil(t, column)
 	assert.Equal(t, "LONGTEXT", column.SQLType.Name)
 
-	table, err = x.TableInfo(new(Notice))
-	require.NoError(t, err)
+	table = tables["notice"]
 	column = table.GetColumn("description")
-	require.NotNil(t, column)
 	assert.Equal(t, "LONGTEXT", column.SQLType.Name)
 }

models/migrations/v1_25/v322_test.go

@@ -10,7 +10,6 @@ import (
 	"code.gitea.io/gitea/modules/setting"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
 )
 
 func Test_ExtendCommentTreePathLength(t *testing.T) {
@@ -26,14 +25,8 @@ func Test_ExtendCommentTreePathLength(t *testing.T) {
 	x, deferrable := base.PrepareTestEnv(t, 0, new(Comment))
 	defer deferrable()
 
-	require.NoError(t, ExtendCommentTreePathLength(x))
-
-	table, err := x.TableInfo(new(Comment))
-	require.NoError(t, err)
-
+	table := base.LoadTableSchemasMap(t, x)["comment"]
 	column := table.GetColumn("tree_path")
-	require.NotNil(t, column)
-
 	assert.Contains(t, []string{"NVARCHAR", "VARCHAR"}, column.SQLType.Name)
 	assert.EqualValues(t, int64(4000), column.Length)
 }