better fix for playwright issue

silverwind · silverwind · commit 9d36023a6745 · 2025-10-31T10:14:29.000+01:00
diff --git a/tests/e2e/example.test.e2e.ts b/tests/e2e/example.test.e2e.ts
@@ -45,8 +45,6 @@ test('login', async ({page}, workerInfo) => {
 
 test('logged in user', async ({browser}, workerInfo) => {
   const context = await load_logged_in_context(browser, workerInfo, 'user2');
-  if (!context) return;
-
   const page = await context.newPage();
   await page.goto('/');
 
diff --git a/tests/e2e/utils_e2e.ts b/tests/e2e/utils_e2e.ts
@@ -33,15 +33,15 @@ export async function login_user(browser: Browser, workerInfo: WorkerInfo, user:
 }
 
 export async function load_logged_in_context(browser: Browser, workerInfo: WorkerInfo, user: string) {
-  let context;
   try {
-    context = await browser.newContext({storageState: `${ARTIFACTS_PATH}/state-${user}-${workerInfo.workerIndex}.json`});
+    return await browser.newContext({storageState: `${ARTIFACTS_PATH}/state-${user}-${workerInfo.workerIndex}.json`});
   } catch (err) {
     if (err.code === 'ENOENT') {
       throw new Error(`Could not find state for '${user}'. Did you call login_user(browser, workerInfo, '${user}') in test.beforeAll()?`);
+    } else {
+      throw err;
     }
   }
-  return context;
 }
 
 export async function save_visual(page: Page) {

Original file line number	Diff line number	Diff line change
`@@ -33,15 +33,15 @@ export async function login_user(browser: Browser, workerInfo: WorkerInfo, user:`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`export async function load_logged_in_context(browser: Browser, workerInfo: WorkerInfo, user: string) {`
`36`		`- let context;`
`37`	`36`	`try {`
`38`		- context = await browser.newContext({storageState: `${ARTIFACTS_PATH}/state-${user}-${workerInfo.workerIndex}.json`});
	`37`	+ return await browser.newContext({storageState: `${ARTIFACTS_PATH}/state-${user}-${workerInfo.workerIndex}.json`});
`39`	`38`	`} catch (err) {`
`40`	`39`	`if (err.code === 'ENOENT') {`
`41`	`40`	throw new Error(`Could not find state for '${user}'. Did you call login_user(browser, workerInfo, '${user}') in test.beforeAll()?`);
	`41`	`+ } else {`
	`42`	`+ throw err;`
`42`	`43`	`}`
`43`	`44`	`}`
`44`		`- return context;`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`export async function save_visual(page: Page) {`