Respect UI.ExploreDefaultSort setting again (#32357) (#32385)

6543 · web-flow · commit 9d62d7a44364 · 2024-10-31T13:49:09.000+08:00
Backport #32357 fix regression of #29430 --- *Sponsored by Kithara Software GmbH*
diff --git a/routers/web/explore/org.go b/routers/web/explore/org.go
@@ -9,6 +9,7 @@ import (
 	"code.gitea.io/gitea/modules/container"
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/structs"
+	"code.gitea.io/gitea/modules/util"
 	"code.gitea.io/gitea/services/context"
 )
 
@@ -33,7 +34,7 @@ func Organizations(ctx *context.Context) {
 	)
 	sortOrder := ctx.FormString("sort")
 	if sortOrder == "" {
-		sortOrder = "newest"
+		sortOrder = util.Iif(supportedSortOrders.Contains(setting.UI.ExploreDefaultSort), setting.UI.ExploreDefaultSort, "newest")
 		ctx.SetFormString("sort", sortOrder)
 	}
 
diff --git a/routers/web/explore/user.go b/routers/web/explore/user.go
@@ -16,6 +16,7 @@ import (
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/sitemap"
 	"code.gitea.io/gitea/modules/structs"
+	"code.gitea.io/gitea/modules/util"
 	"code.gitea.io/gitea/services/context"
 )
 
@@ -147,7 +148,7 @@ func Users(ctx *context.Context) {
 	)
 	sortOrder := ctx.FormString("sort")
 	if sortOrder == "" {
-		sortOrder = "newest"
+		sortOrder = util.Iif(supportedSortOrders.Contains(setting.UI.ExploreDefaultSort), setting.UI.ExploreDefaultSort, "newest")
 		ctx.SetFormString("sort", sortOrder)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ import (`
`9`	`9`	`"code.gitea.io/gitea/modules/container"`
`10`	`10`	`"code.gitea.io/gitea/modules/setting"`
`11`	`11`	`"code.gitea.io/gitea/modules/structs"`
	`12`	`+ "code.gitea.io/gitea/modules/util"`
`12`	`13`	`"code.gitea.io/gitea/services/context"`
`13`	`14`	`)`
`14`	`15`
`@@ -33,7 +34,7 @@ func Organizations(ctx *context.Context) {`
`33`	`34`	`)`
`34`	`35`	`sortOrder := ctx.FormString("sort")`
`35`	`36`	`if sortOrder == "" {`
`36`		`- sortOrder = "newest"`
	`37`	`+ sortOrder = util.Iif(supportedSortOrders.Contains(setting.UI.ExploreDefaultSort), setting.UI.ExploreDefaultSort, "newest")`
`37`	`38`	`ctx.SetFormString("sort", sortOrder)`
`38`	`39`	`}`
`39`	`40`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ import (`
`16`	`16`	`"code.gitea.io/gitea/modules/setting"`
`17`	`17`	`"code.gitea.io/gitea/modules/sitemap"`
`18`	`18`	`"code.gitea.io/gitea/modules/structs"`
	`19`	`+ "code.gitea.io/gitea/modules/util"`
`19`	`20`	`"code.gitea.io/gitea/services/context"`
`20`	`21`	`)`
`21`	`22`
`@@ -147,7 +148,7 @@ func Users(ctx *context.Context) {`
`147`	`148`	`)`
`148`	`149`	`sortOrder := ctx.FormString("sort")`
`149`	`150`	`if sortOrder == "" {`
`150`		`- sortOrder = "newest"`
	`151`	`+ sortOrder = util.Iif(supportedSortOrders.Contains(setting.UI.ExploreDefaultSort), setting.UI.ExploreDefaultSort, "newest")`
`151`	`152`	`ctx.SetFormString("sort", sortOrder)`
`152`	`153`	`}`
`153`	`154`