Skip to content

Commit a1830dc

Browse files
authored
Merge pull request #3 from lunny/add-file-tree-to-file-view-page
Fix a TODO
2 parents 6cb22e5 + f2b1da5 commit a1830dc

File tree

2 files changed

+13
-4
lines changed

2 files changed

+13
-4
lines changed

routers/web/repo/tree.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88

99
"code.gitea.io/gitea/modules/base"
1010
"code.gitea.io/gitea/modules/git"
11+
"code.gitea.io/gitea/modules/gitrepo"
1112
"code.gitea.io/gitea/services/context"
1213
files_service "code.gitea.io/gitea/services/repository/files"
1314

@@ -59,10 +60,18 @@ func Tree(ctx *context.Context) {
5960
ref := ctx.FormTrim("ref")
6061
recursive := ctx.FormBool("recursive")
6162

62-
// TODO: Only support branch for now
63-
results, err := files_service.GetTreeList(ctx, ctx.Repo.Repository, dir, git.RefNameFromBranch(ref), recursive)
63+
gitRepo, closer, err := gitrepo.RepositoryFromContextOrOpen(ctx, ctx.Repo.Repository)
6464
if err != nil {
65-
ctx.ServerError("guessRefInfoAndDir", err)
65+
ctx.ServerError("RepositoryFromContextOrOpen", err)
66+
return
67+
}
68+
defer closer.Close()
69+
70+
refName := gitRepo.UnstableGuessRefByShortName(ref)
71+
72+
results, err := files_service.GetTreeList(ctx, ctx.Repo.Repository, dir, refName, recursive)
73+
if err != nil {
74+
ctx.ServerError("GetTreeList", err)
6675
return
6776
}
6877

services/repository/files/tree.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ func GetTreeList(ctx context.Context, repo *repo_model.Repository, treePath stri
140140
// Check that the path given in opts.treePath is valid (not a git path)
141141
cleanTreePath := CleanUploadFileName(treePath)
142142
if cleanTreePath == "" && treePath != "" {
143-
return nil, models.ErrFilenameInvalid{
143+
return nil, ErrFilenameInvalid{
144144
Path: treePath,
145145
}
146146
}

0 commit comments

Comments
 (0)