Add test and fix bug

Author: lunny

models/issues/issue.go

@@ -519,11 +519,14 @@ func FindLatestIssues(ctx context.Context, repoID int64, isPull optional.Option[
 	return issues, err
 }
 
-func FindIssuesTitleKeywords(ctx context.Context, repoID int64, keyword string, isPull optional.Option[bool], pageSize int) (IssueList, error) {
+func FindIssuesTitleKeywords(ctx context.Context, repoID int64, keyword string, isPull optional.Option[bool], nonIDs []int64, pageSize int) (IssueList, error) {
 	issues := make([]*Issue, 0, pageSize)
-	err := db.GetEngine(ctx).Where("repo_id = ?", repoID).
-		And(isPullToCond(isPull)).
-		And("name LIKE ?", "%"+keyword+"%").
+	sess := db.GetEngine(ctx).Where("repo_id = ?", repoID).
+		And(isPullToCond(isPull))
+	if len(nonIDs) > 0 {
+		sess.NotIn("id", nonIDs)
+	}
+	err := sess.And("name LIKE ?", "%"+keyword+"%").
 		OrderBy("created_unix DESC").
 		Limit(pageSize).
 		Find(&issues)

services/issue/suggestion.go

@@ -24,16 +24,20 @@ func GetSuggestion(ctx context.Context, repo *repo_model.Repository, isPull opti
 		}
 	} else {
 		indexKeyword, _ := strconv.ParseInt(keyword, 10, 64)
+		nonIDs := []int64{}
 		if indexKeyword > 0 {
 			issues, err = issues_model.FindIssuesWithIndexPrefix(ctx, repo.ID, indexKeyword, isPull, pageSize)
 			if err != nil {
 				return nil, err
 			}
+			for _, issue := range issues {
+				nonIDs = append(nonIDs, issue.ID)
+			}
 			pageSize -= len(issues)
 		}
 
 		if pageSize > 0 {
-			newIssues, err := issues_model.FindIssuesTitleKeywords(ctx, repo.ID, keyword, isPull, pageSize)
+			newIssues, err := issues_model.FindIssuesTitleKeywords(ctx, repo.ID, keyword, isPull, nonIDs, pageSize)
 			if err != nil {
 				return nil, err
 			}

services/issue/suggestion_test.go

@@ -0,0 +1,57 @@
+// Copyright 2025 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package issue
+
+import (
+	"testing"
+
+	"code.gitea.io/gitea/models/db"
+	repo_model "code.gitea.io/gitea/models/repo"
+	"code.gitea.io/gitea/models/unittest"
+	"code.gitea.io/gitea/modules/optional"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_Suggestion(t *testing.T) {
+	assert.NoError(t, unittest.PrepareTestDatabase())
+
+	repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
+
+	testCases := []struct {
+		keyword         string
+		isPull          optional.Option[bool]
+		expectedIndexes []int64
+	}{
+		{
+			keyword:         "",
+			expectedIndexes: []int64{5, 4, 3, 2, 1},
+		},
+		{
+			keyword:         "1",
+			expectedIndexes: []int64{1},
+		},
+		{
+			keyword:         "issue",
+			expectedIndexes: []int64{4, 3, 2, 1},
+		},
+		{
+			keyword:         "pull",
+			expectedIndexes: []int64{5},
+		},
+	}
+
+	for _, testCase := range testCases {
+		t.Run(testCase.keyword, func(t *testing.T) {
+			issues, err := GetSuggestion(db.DefaultContext, repo1, testCase.isPull, testCase.keyword)
+			assert.NoError(t, err)
+
+			issueIndexes := make([]int64, 0, len(issues))
+			for _, issue := range issues {
+				issueIndexes = append(issueIndexes, issue.Index)
+			}
+			assert.EqualValues(t, testCase.expectedIndexes, issueIndexes)
+		})
+	}
+}