Merge remote-tracking branch 'upstream/main' into pubsub

Author: anbraten

.devcontainer/devcontainer.json

@@ -1,12 +1,12 @@
 {
   "name": "Gitea DevContainer",
-  "image": "mcr.microsoft.com/devcontainers/go:1.22-bullseye",
+  "image": "mcr.microsoft.com/devcontainers/go:1.23-bookworm",
   "features": {
     // installs nodejs into container
     "ghcr.io/devcontainers/features/node:1": {
       "version": "20"
     },
-    "ghcr.io/devcontainers/features/git-lfs:1.1.0": {},
+    "ghcr.io/devcontainers/features/git-lfs:1.2.2": {},
     "ghcr.io/devcontainers-contrib/features/poetry:2": {},
     "ghcr.io/devcontainers/features/python:1": {
       "version": "3.12"

.envrc

@@ -0,0 +1 @@
+use flake

.eslintrc.yaml

@@ -47,7 +47,6 @@ overrides:
   - files: ["web_src/**/*"]
     globals:
       __webpack_public_path__: true
-      htmx: true
       process: false # https://github.com/webpack/webpack/issues/15833
   - files: ["web_src/**/*", "docs/**/*"]
     env:
@@ -58,7 +57,15 @@ overrides:
       worker: true
     rules:
       no-restricted-globals: [2, addEventListener, blur, close, closed, confirm, defaultStatus, defaultstatus, error, event, external, find, focus, frameElement, frames, history, innerHeight, innerWidth, isFinite, isNaN, length, locationbar, menubar, moveBy, moveTo, name, onblur, onerror, onfocus, onload, onresize, onunload, open, opener, opera, outerHeight, outerWidth, pageXOffset, pageYOffset, parent, print, removeEventListener, resizeBy, resizeTo, screen, screenLeft, screenTop, screenX, screenY, scroll, scrollbars, scrollBy, scrollTo, scrollX, scrollY, status, statusbar, stop, toolbar, top]
-  - files: ["*.config.*", "**/*.d.ts"]
+  - files: ["*.config.*"]
+    rules:
+      i/no-unused-modules: [0]
+  - files: ["**/*.d.ts"]
+    rules:
+      i/no-unused-modules: [0]
+      "@typescript-eslint/consistent-type-definitions": [0]
+      "@typescript-eslint/consistent-type-imports": [0]
+  - files: ["web_src/js/types.ts"]
     rules:
       i/no-unused-modules: [0]
   - files: ["**/*.test.*", "web_src/js/test/setup.ts"]
@@ -217,7 +224,6 @@ rules:
   "@typescript-eslint/await-thenable": [2]
   "@typescript-eslint/ban-ts-comment": [2, {'ts-expect-error': false, 'ts-ignore': true, 'ts-nocheck': false, 'ts-check': false}]
   "@typescript-eslint/ban-tslint-comment": [0]
-  "@typescript-eslint/ban-types": [2, {extendDefaults: true, types: {Function: false}}]
   "@typescript-eslint/class-literal-property-style": [0]
   "@typescript-eslint/class-methods-use-this": [0]
   "@typescript-eslint/consistent-generic-constructors": [0]
@@ -248,6 +254,7 @@ rules:
   "@typescript-eslint/no-dynamic-delete": [0]
   "@typescript-eslint/no-empty-function": [0]
   "@typescript-eslint/no-empty-interface": [0]
+  "@typescript-eslint/no-empty-object-type": [2]
   "@typescript-eslint/no-explicit-any": [0]
   "@typescript-eslint/no-extra-non-null-assertion": [2]
   "@typescript-eslint/no-extraneous-class": [0]
@@ -259,7 +266,7 @@ rules:
   "@typescript-eslint/no-invalid-this": [0]
   "@typescript-eslint/no-invalid-void-type": [0]
   "@typescript-eslint/no-loop-func": [0]
-  "@typescript-eslint/no-loss-of-precision": [2]
+  "@typescript-eslint/no-loss-of-precision": [0]
   "@typescript-eslint/no-magic-numbers": [0]
   "@typescript-eslint/no-meaningless-void-operator": [0]
   "@typescript-eslint/no-misused-new": [2]
@@ -271,8 +278,9 @@ rules:
   "@typescript-eslint/no-non-null-assertion": [0]
   "@typescript-eslint/no-redeclare": [0]
   "@typescript-eslint/no-redundant-type-constituents": [2]
-  "@typescript-eslint/no-require-imports": [0]
+  "@typescript-eslint/no-require-imports": [2]
   "@typescript-eslint/no-restricted-imports": [0]
+  "@typescript-eslint/no-restricted-types": [0]
   "@typescript-eslint/no-shadow": [0]
   "@typescript-eslint/no-this-alias": [0] # handled by unicorn/no-this-assignment
   "@typescript-eslint/no-unnecessary-boolean-literal-compare": [0]
@@ -287,6 +295,7 @@ rules:
   "@typescript-eslint/no-unsafe-call": [0]
   "@typescript-eslint/no-unsafe-declaration-merging": [2]
   "@typescript-eslint/no-unsafe-enum-comparison": [2]
+  "@typescript-eslint/no-unsafe-function-type": [2]
   "@typescript-eslint/no-unsafe-member-access": [0]
   "@typescript-eslint/no-unsafe-return": [0]
   "@typescript-eslint/no-unsafe-unary-minus": [2]
@@ -295,7 +304,7 @@ rules:
   "@typescript-eslint/no-use-before-define": [0]
   "@typescript-eslint/no-useless-constructor": [0]
   "@typescript-eslint/no-useless-empty-export": [0]
-  "@typescript-eslint/no-var-requires": [2]
+  "@typescript-eslint/no-wrapper-object-types": [2]
   "@typescript-eslint/non-nullable-type-assertion-style": [0]
   "@typescript-eslint/only-throw-error": [2]
   "@typescript-eslint/parameter-properties": [0]
@@ -327,7 +336,7 @@ rules:
   "@typescript-eslint/switch-exhaustiveness-check": [0]
   "@typescript-eslint/triple-slash-reference": [2]
   "@typescript-eslint/typedef": [0]
-  "@typescript-eslint/unbound-method": [2]
+  "@typescript-eslint/unbound-method": [0] # too many false-positives
   "@typescript-eslint/unified-signatures": [2]
   accessor-pairs: [2]
   array-callback-return: [2, {checkForEach: true}]
@@ -505,7 +514,7 @@ rules:
   no-jquery/no-box-model: [2]
   no-jquery/no-browser: [2]
   no-jquery/no-camel-case: [2]
-  no-jquery/no-class-state: [0]
+  no-jquery/no-class-state: [2]
   no-jquery/no-class: [0]
   no-jquery/no-clone: [2]
   no-jquery/no-closest: [0]
@@ -561,7 +570,7 @@ rules:
   no-jquery/no-param: [2]
   no-jquery/no-parent: [0]
   no-jquery/no-parents: [2]
-  no-jquery/no-parse-html-literal: [0]
+  no-jquery/no-parse-html-literal: [2]
   no-jquery/no-parse-html: [2]
   no-jquery/no-parse-json: [2]
   no-jquery/no-parse-xml: [2]
@@ -592,7 +601,7 @@ rules:
   no-lone-blocks: [2]
   no-lonely-if: [0]
   no-loop-func: [0]
-  no-loss-of-precision: [0] # handled by @typescript-eslint/no-loss-of-precision
+  no-loss-of-precision: [2]
   no-magic-numbers: [0]
   no-misleading-character-class: [2]
   no-multi-assign: [0]
@@ -836,6 +845,7 @@ rules:
   unicorn/no-invalid-fetch-options: [2]
   unicorn/no-invalid-remove-event-listener: [2]
   unicorn/no-keyword-prefix: [0]
+  unicorn/no-length-as-slice-end: [2]
   unicorn/no-lonely-if: [2]
   unicorn/no-magic-array-flat-depth: [0]
   unicorn/no-negated-condition: [0]

.github/ISSUE_TEMPLATE/bug-report.yaml

@@ -11,7 +11,7 @@ body:
       value: |
         1. Please speak English, this is the language all maintainers can speak and write.
         2. Please ask questions or configuration/deploy problems on our Discord
-           server (https://discord.gg/gitea) or forum (https://discourse.gitea.io).
+           server (https://discord.gg/gitea) or forum (https://forum.gitea.com).
         3. Make sure you are using the latest release and
            take a moment to check that your issue hasn't been reported before.
         4. Make sure it's not mentioned in the FAQ (https://docs.gitea.com/help/faq)

.github/ISSUE_TEMPLATE/config.yml

@@ -7,7 +7,7 @@ contact_links:
     url: https://discord.gg/Gitea
     about: Please ask questions and discuss configuration or deployment problems here.
   - name: Discourse Forum
-    url: https://discourse.gitea.io
+    url: https://forum.gitea.com
     about: Questions and configuration or deployment problems can also be discussed on our forum.
   - name: Frequently Asked Questions
     url: https://docs.gitea.com/help/faq

.github/ISSUE_TEMPLATE/feature-request.yaml

@@ -7,7 +7,7 @@ body:
       value: |
         1. Please speak English, this is the language all maintainers can speak and write.
         2. Please ask questions or configuration/deploy problems on our Discord
-           server (https://discord.gg/gitea) or forum (https://discourse.gitea.io).
+           server (https://discord.gg/gitea) or forum (https://forum.gitea.com).
         3. Please take a moment to check that your feature hasn't already been suggested.
   - type: textarea
     id: description

.github/ISSUE_TEMPLATE/ui.bug-report.yaml

@@ -11,7 +11,7 @@ body:
       value: |
         1. Please speak English, this is the language all maintainers can speak and write.
         2. Please ask questions or configuration/deploy problems on our Discord
-           server (https://discord.gg/gitea) or forum (https://discourse.gitea.io).
+           server (https://discord.gg/gitea) or forum (https://forum.gitea.com).
         3. Please take a moment to check that your issue doesn't already exist.
         4. Make sure it's not mentioned in the FAQ (https://docs.gitea.com/help/faq)
         5. Please give all relevant information below for bug reports, because

.github/labeler.yml

@@ -75,3 +75,8 @@ modifies/js:
       - any-glob-to-any-file:
           - "**/*.js"
           - "**/*.vue"
+
+docs-update-needed:
+  - changed-files:
+      - any-glob-to-any-file:
+          - "custom/conf/app.example.ini"

.github/workflows/files-changed.yml

@@ -63,7 +63,6 @@ jobs:
 
             docs:
               - "**/*.md"
-              - "docs/**"
               - ".markdownlint.yaml"
               - "package.json"
               - "package-lock.json"

.github/workflows/pull-compliance.yml

@@ -191,7 +191,6 @@ jobs:
           cache-dependency-path: package-lock.json
       - run: make deps-frontend
       - run: make lint-md
-      - run: make docs
 
   actions:
     if: needs.files-changed.outputs.actions == 'true' || needs.files-changed.outputs.actions == 'true'