fix npe error

kerwin612 · kerwin612 · commit aabfc86a673b · 2025-04-15T08:44:37.000Z
diff --git a/services/gitdiff/gitdiff.go b/services/gitdiff/gitdiff.go
@@ -1339,7 +1339,7 @@ func GetDiffShortStat(gitRepo *git.Repository, beforeCommitID, afterCommitID str
 // Additionally, the database is updated asynchronously if files have changed since the last review
 func SyncUserSpecificDiff(ctx context.Context, userID int64, pull *issues_model.PullRequest, gitRepo *git.Repository, diff *Diff, opts *DiffOptions) (*pull_model.ReviewState, error) {
 	review, err := pull_model.GetNewestReviewState(ctx, userID, pull.ID)
-	if err != nil {
+	if err != nil || review == nil || review.UpdatedFiles == nil {
 		return nil, err
 	}
 	if len(review.UpdatedFiles) == 0 {

Original file line number	Diff line number	Diff line change
`@@ -1339,7 +1339,7 @@ func GetDiffShortStat(gitRepo *git.Repository, beforeCommitID, afterCommitID str`
`1339`	`1339`	`// Additionally, the database is updated asynchronously if files have changed since the last review`
`1340`	`1340`	`func SyncUserSpecificDiff(ctx context.Context, userID int64, pull issues_model.PullRequest, gitRepo git.Repository, diff Diff, opts DiffOptions) (*pull_model.ReviewState, error) {`
`1341`	`1341`	`review, err := pull_model.GetNewestReviewState(ctx, userID, pull.ID)`
`1342`		`- if err != nil {`
	`1342`	`+ if err != nil \|\| review == nil \|\| review.UpdatedFiles == nil {`
`1343`	`1343`	`return nil, err`
`1344`	`1344`	`}`
`1345`	`1345`	`if len(review.UpdatedFiles) == 0 {`