Improvements

Author: lunny

modules/git/batch_reader.go

@@ -68,7 +68,6 @@ func ReadBatchLine(rd *bufio.Reader) (sha []byte, typ string, size int64, err er
 	typ = typ[:idx]
 
 	size, err = strconv.ParseInt(sizeStr, 10, 64)
-
 	return sha, typ, size, err
 }
 

modules/git/commit_info_nogogit.go

@@ -130,7 +130,7 @@ func GetLastCommitForPaths(ctx context.Context, commit *Commit, treePath string,
 	}
 	defer cancel()
 
-	rd := batch.Reader()
+	batchReader := batch.Reader()
 
 	commitsMap := map[string]*Commit{}
 	commitsMap[commit.ID.String()] = commit
@@ -150,21 +150,21 @@ func GetLastCommitForPaths(ctx context.Context, commit *Commit, treePath string,
 		if err := batch.Input(commitID); err != nil {
 			return nil, err
 		}
-		_, typ, size, err := ReadBatchLine(rd)
+		_, typ, size, err := ReadBatchLine(batchReader)
 		if err != nil {
 			return nil, err
 		}
 		if typ != "commit" {
-			if err := DiscardFull(rd, size+1); err != nil {
+			if err := DiscardFull(batchReader, size+1); err != nil {
 				return nil, err
 			}
 			return nil, fmt.Errorf("unexpected type: %s for commit id: %s", typ, commitID)
 		}
-		c, err = CommitFromReader(commit.repo, MustIDFromString(commitID), io.LimitReader(rd, size))
+		c, err = CommitFromReader(commit.repo, MustIDFromString(commitID), io.LimitReader(batchReader, size))
 		if err != nil {
 			return nil, err
 		}
-		if _, err := rd.Discard(1); err != nil {
+		if _, err := batchReader.Discard(1); err != nil {
 			return nil, err
 		}
 		commitCommits[path] = c

modules/git/pipeline/lfs_nogogit.go

@@ -137,7 +137,6 @@ func FindLFSFile(repo *git.Repository, objectID git.ObjectID) ([]*LFSResult, err
 					if err := batch.Input(string(trees[len(trees)-1])); err != nil {
 						return nil, err
 					}
-
 					curPath = paths[len(paths)-1]
 					trees = trees[:len(trees)-1]
 					paths = paths[:len(paths)-1]