Reduce paging inconsistency

* disallow bypassing configured limits in api
* allow per_page without documenting it
* allow limit for the only endpoint only allowing per_page

This is an paging inconsistency api review, please comment your opinion about the added code comments

* 	ctx.SetLinkHeader(int(totalNumOfBranches), listOptions.PageSize) missing for several api endpoints should I add them everywhere?

* do we want to accept per_page in api?
  * better compatibility with existing keda github_runner

Author: ChristopherHX

models/issues/issue.go

@@ -690,6 +690,7 @@ func (issue *Issue) BlockedByDependencies(ctx context.Context, opts db.ListOptio
 		Where("issue_id = ?", issue.ID).
 		// sort by repo id then created date, with the issues of the same repo at the beginning of the list
 		OrderBy("CASE WHEN issue.repo_id = ? THEN 0 ELSE issue.repo_id END, issue.created_unix DESC", issue.RepoID)
+	// Pagination bypass needed by ViewIssue => prepareIssueViewSidebarDependency
 	if opts.Page > 0 {
 		sess = db.SetSessionPagination(sess, &opts)
 	}

models/issues/issue_watch.go

@@ -105,12 +105,9 @@ func GetIssueWatchers(ctx context.Context, issueID int64, listOptions db.ListOpt
 		And("`user`.prohibit_login = ?", false).
 		Join("INNER", "`user`", "`user`.id = `issue_watch`.user_id")
 
-	if listOptions.Page > 0 {
-		sess = db.SetSessionPagination(sess, &listOptions)
-		watches := make([]*IssueWatch, 0, listOptions.PageSize)
-		return watches, sess.Find(&watches)
-	}
-	watches := make([]*IssueWatch, 0, 8)
+	listOptions.SetDefaultValues()
+	sess = db.SetSessionPagination(sess, &listOptions)
+	watches := make([]*IssueWatch, 0, listOptions.PageSize)
 	return watches, sess.Find(&watches)
 }
 

models/issues/label.go

@@ -408,6 +408,7 @@ func GetLabelsByRepoID(ctx context.Context, repoID int64, sortType string, listO
 		sess.Asc("name")
 	}
 
+	// Pagination bypass used by some callers
 	if listOptions.Page > 0 {
 		sess = db.SetSessionPagination(sess, &listOptions)
 	}
@@ -483,6 +484,7 @@ func GetLabelsByOrgID(ctx context.Context, orgID int64, sortType string, listOpt
 		sess.Asc("name")
 	}
 
+	// Why can we bypass limits here?
 	if listOptions.Page > 0 {
 		sess = db.SetSessionPagination(sess, &listOptions)
 	}

models/issues/review.go

@@ -389,6 +389,7 @@ func GetCurrentReview(ctx context.Context, reviewer *user_model.User, issue *Iss
 	if reviewer == nil {
 		return nil, nil
 	}
+	// Missing db.ListOptionsAll
 	reviews, err := FindReviews(ctx, FindReviewOptions{
 		Types:      []ReviewType{ReviewTypePending},
 		IssueID:    issue.ID,

models/issues/review_list.go

@@ -120,6 +120,7 @@ func (opts *FindReviewOptions) toCond() builder.Cond {
 func FindReviews(ctx context.Context, opts FindReviewOptions) (ReviewList, error) {
 	reviews := make([]*Review, 0, 10)
 	sess := db.GetEngine(ctx).Where(opts.toCond())
+	// Pagination bypass used by some callers
 	if opts.Page > 0 && !opts.IsListAll() {
 		sess = db.SetSessionPagination(sess, &opts)
 	}

models/issues/stopwatch.go

@@ -91,6 +91,7 @@ func GetUIDsAndStopwatch(ctx context.Context) ([]*UserStopwatch, error) {
 func GetUserStopwatches(ctx context.Context, userID int64, listOptions db.ListOptions) ([]*Stopwatch, error) {
 	sws := make([]*Stopwatch, 0, 8)
 	sess := db.GetEngine(ctx).Where("stopwatch.user_id = ?", userID)
+	// Pagination bypass used by CancelStopwatch
 	if listOptions.Page > 0 {
 		sess = db.SetSessionPagination(sess, &listOptions)
 	}

models/packages/package_version.go

@@ -187,6 +187,7 @@ type PackageSearchOptions struct {
 	HasFileWithName string                // only results are found which are associated with a file with the specific name
 	HasFiles        optional.Option[bool] // only results are found which have associated files
 	Sort            VersionSort
+	// Only one with interface
 	db.Paginator
 }
 

models/repo/star.go

@@ -79,6 +79,7 @@ func IsStaring(ctx context.Context, userID, repoID int64) bool {
 func GetStargazers(ctx context.Context, repo *Repository, opts db.ListOptions) ([]*user_model.User, error) {
 	sess := db.GetEngine(ctx).Where("star.repo_id = ?", repo.ID).
 		Join("LEFT", "star", "`user`.id = star.uid")
+	// Paging bypass used by UI
 	if opts.Page > 0 {
 		sess = db.SetSessionPagination(sess, &opts)
 

models/repo/watch.go

@@ -151,14 +151,9 @@ func GetRepoWatchers(ctx context.Context, repoID int64, opts db.ListOptions) ([]
 	sess := db.GetEngine(ctx).Where("watch.repo_id=?", repoID).
 		Join("LEFT", "watch", "`user`.id=`watch`.user_id").
 		And("`watch`.mode<>?", WatchModeDont)
-	if opts.Page > 0 {
-		sess = db.SetSessionPagination(sess, &opts)
-		users := make([]*user_model.User, 0, opts.PageSize)
+	sess = db.SetSessionPagination(sess, &opts)
+	users := make([]*user_model.User, 0, opts.PageSize)
 
-		return users, sess.Find(&users)
-	}
-
-	users := make([]*user_model.User, 0, 8)
 	return users, sess.Find(&users)
 }
 

models/user/search.go

@@ -151,6 +151,7 @@ func SearchUsers(ctx context.Context, opts SearchUserOptions) (users []*User, _
 
 	sessQuery := opts.toSearchQueryBase(ctx).OrderBy(opts.OrderBy.String())
 	defer sessQuery.Close()
+	// Pagination bypass used by UI
 	if opts.Page > 0 {
 		sessQuery = db.SetSessionPagination(sessQuery, &opts)
 	}