correct names

Author: lunny

models/git/combined_status.go

@@ -82,11 +82,11 @@ func GetLatestCombinedStatusForRepoAndSHAs(ctx context.Context, repoSHAs []RepoS
 		cond = cond.Or(builder.Eq{"repo_id": rs.RepoID, "sha": rs.SHA})
 	}
 
-	var summaries []*CombinedStatus
-	if err := db.GetEngine(ctx).Where(cond).Find(&summaries); err != nil {
+	combinedStatuses := make([]*CombinedStatus, 0, len(repoSHAs))
+	if err := db.GetEngine(ctx).Where(cond).Find(&combinedStatuses); err != nil {
 		return nil, err
 	}
-	return summaries, nil
+	return combinedStatuses, nil
 }
 
 func InsertOrUpdateCombinedStatus(ctx context.Context, repoID int64, sha string) error {

services/pull/pull.go

@@ -998,14 +998,13 @@ func GetIssuesAllCommitStatus(ctx context.Context, issues issues_model.IssueList
 }
 
 // getAllCommitStatus get pr's commit statuses.
-func getAllCommitStatus(ctx context.Context, gitRepo *git.Repository, pr *issues_model.PullRequest) (statuses []*git_model.CommitStatus, err error) {
+func getAllCommitStatus(ctx context.Context, gitRepo *git.Repository, pr *issues_model.PullRequest) ([]*git_model.CommitStatus, error) {
 	sha, shaErr := gitRepo.GetRefCommitID(pr.GetGitRefName())
 	if shaErr != nil {
 		return nil, shaErr
 	}
 
-	statuses, err = git_model.GetLatestCommitStatus(ctx, pr.BaseRepo.ID, sha, db.ListOptionsAll)
-	return statuses, err
+	return git_model.GetLatestCommitStatus(ctx, pr.BaseRepo.ID, sha, db.ListOptionsAll)
 }
 
 // IsHeadEqualWithBranch returns if the commits of branchName are available in pull request head

services/repository/commitstatus/commitstatus.go

@@ -158,15 +158,15 @@ func FindReposLastestCombinedStatuses(ctx context.Context, repos []*repo_model.R
 		repoSHAs = append(repoSHAs, git_model.RepoSHA{RepoID: id, SHA: sha})
 	}
 
-	summaryResults, err := git_model.GetLatestCombinedStatusForRepoAndSHAs(ctx, repoSHAs)
+	combinedStatuses, err := git_model.GetLatestCombinedStatusForRepoAndSHAs(ctx, repoSHAs)
 	if err != nil {
 		return nil, fmt.Errorf("GetLatestCommitStatusForRepoAndSHAs: %v", err)
 	}
 
-	for _, summary := range summaryResults {
+	for _, combinedStatus := range combinedStatuses {
 		for i, repo := range repos {
-			if repo.ID == summary.RepoID {
-				results[i] = summary
+			if repo.ID == combinedStatus.RepoID {
+				results[i] = combinedStatus
 				repoSHAs = slices.DeleteFunc(repoSHAs, func(repoSHA git_model.RepoSHA) bool {
 					return repoSHA.RepoID == repo.ID
 				})