Just allow a...b and a..b two kinds of parameter

Author: lunny

modules/git/repo_compare.go

@@ -233,6 +233,10 @@ func parseDiffStat(stdout string) (numFiles, totalAdditions, totalDeletions int,
 	return numFiles, totalAdditions, totalDeletions, err
 }
 
+// parseCompareArgs parses the compareArgs string into a slice of arguments
+// Only supports the following formats:
+// - "base...head"
+// - "base..head"
 func parseCompareArgs(compareArgs string) (args []string) {
 	parts := strings.Split(compareArgs, "...")
 	if len(parts) == 2 {
@@ -242,10 +246,6 @@ func parseCompareArgs(compareArgs string) (args []string) {
 	if len(parts) == 2 {
 		return parts
 	}
-	parts = strings.Fields(compareArgs)
-	if len(parts) == 2 {
-		return parts
-	}
 
 	return nil
 }

modules/git/repo_compare_test.go

@@ -21,10 +21,6 @@ func Test_parseCompareArgs(t *testing.T) {
 			"master..develop",
 			[]string{"master", "develop"},
 		},
-		{
-			"master HEAD",
-			[]string{"master", "HEAD"},
-		},
 		{
 			"HEAD...develop",
 			[]string{"HEAD...develop"},