Update

Author: hiifong

custom/conf/app.example.ini

@@ -1258,71 +1258,91 @@ LEVEL = Info
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 ;;
 ;; Number of repositories that are displayed on one explore page
+;; Deprecated in v1.24
 ;EXPLORE_PAGING_NUM = 20
 ;;
 ;; Number of issues that are displayed on one page
+;; Deprecated in v1.24
 ;ISSUE_PAGING_NUM = 20
 ;;
 ;; Number of maximum commits displayed in one activity feed
+;; Deprecated in v1.24
 ;FEED_MAX_COMMIT_NUM = 5
 ;;
 ;; Number of items that are displayed in home feed
+;; Deprecated in v1.24
 ;FEED_PAGING_NUM = 20
 ;;
 ;; Number of items that are displayed in a single subsitemap
+;; Deprecated in v1.24
 ;SITEMAP_PAGING_NUM = 20
 ;;
 ;; Number of maximum commits displayed in commit graph.
+;; Deprecated in v1.24
 ;GRAPH_MAX_COMMIT_NUM = 100
 ;;
 ;; Number of line of codes shown for a code comment
+;; Deprecated in v1.24
 ;CODE_COMMENT_LINES = 4
 ;;
 ;; Max size of files to be displayed (default is 8MiB)
+;; Deprecated in v1.24
 ;MAX_DISPLAY_FILE_SIZE = 8388608
 ;;
 ;; Detect ambiguous unicode characters in file contents and show warnings on the UI
+;; Deprecated in v1.24
 ;AMBIGUOUS_UNICODE_DETECTION = true
 ;;
 ;; Whether the email of the user should be shown in the Explore Users page
+;; Deprecated in v1.24
 ;SHOW_USER_EMAIL = true
 ;;
 ;; Set the default theme for the Gitea install
+;; Deprecated in v1.24
 ;DEFAULT_THEME = gitea-auto
 ;;
 ;; All available themes. Allow users select personalized themes regardless of the value of `DEFAULT_THEME`.
 ;; Leave it empty to allow users to select any theme from "{CustomPath}/public/assets/css/theme-*.css"
+;; Deprecated in v1.24
 ;THEMES =
 ;;
 ;; All available reactions users can choose on issues/prs and comments.
 ;; Values can be emoji alias (:smile:) or a unicode emoji.
 ;; For custom reactions, add a tightly cropped square image to public/assets/img/emoji/reaction_name.png
+;; Deprecated in v1.24
 ;REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes
 ;;
 ;; Change the number of users that are displayed in reactions tooltip (triggered by mouse hover).
+;; Deprecated in v1.24
 ;REACTION_MAX_USER_NUM = 10
 ;;
 ;; Additional Emojis not defined in the utf8 standard
 ;; By default we support gitea (:gitea:), to add more copy them to public/assets/img/emoji/emoji_name.png and add it to this config.
 ;; Dont mistake it for Reactions.
+;; Deprecated in v1.24
 ;CUSTOM_EMOJIS = gitea, codeberg, gitlab, git, github, gogs
 ;;
 ;; Whether the full name of the users should be shown where possible. If the full name isn't set, the username will be used.
+;; Deprecated in v1.24
 ;DEFAULT_SHOW_FULL_NAME = false
 ;;
 ;; Whether to search within description at repository search on explore page.
+;; Deprecated in v1.24
 ;SEARCH_REPO_DESCRIPTION = true
 ;;
 ;; Whether to only show relevant repos on the explore page when no keyword is specified and default sorting is used.
 ;; A repo is considered irrelevant if it's a fork or if it has no metadata (no description, no icon, no topic).
+;; Deprecated in v1.24
 ;ONLY_SHOW_RELEVANT_REPOS = false
 ;;
 ;; Change the sort type of the explore pages.
 ;; Default is "recentupdate", but you also have "alphabetically", "reverselastlogin", "newest", "oldest".
+;; Deprecated in v1.24
 ;EXPLORE_PAGING_DEFAULT_SORT = recentupdate
 ;;
 ;; The tense all timestamps should be rendered in. Possible values are `absolute` time (i.e. 1970-01-01, 11:59) and `mixed`.
 ;; `mixed` means most timestamps are rendered in relative time (i.e. 2 days ago).
+;; Deprecated in v1.24
 ;PREFERRED_TIMESTAMP_TENSE = mixed
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

models/migrations/migrations.go

@@ -374,6 +374,7 @@ func prepareMigrationTasks() []*migration {
 		// Gitea 1.23.0-rc0 ends at migration ID number 311 (database version 312)
 		newMigration(312, "Add DeleteBranchAfterMerge to AutoMerge", v1_24.AddDeleteBranchAfterMergeForAutoMerge),
 		newMigration(313, "Move PinOrder from issue table to a new table issue_pin", v1_24.MovePinOrderToTableIssuePin),
+		newMigration(314, "Migrate the configuration of the ui section of the ini configuration file to the system setting table.", v1_24.MigrateIniToDatabase),
 	}
 	return preparedMigrations
 }

models/migrations/v1_24/v314.go

@@ -0,0 +1,89 @@
+// Copyright 2025 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package v1_24 //nolint
+
+import (
+	"math"
+
+	system_model "code.gitea.io/gitea/models/system"
+	"code.gitea.io/gitea/modules/setting"
+	"code.gitea.io/gitea/modules/timeutil"
+	"code.gitea.io/gitea/modules/util"
+
+	"xorm.io/xorm"
+)
+
+const keyRevision = "revision"
+
+type Setting struct {
+	ID           int64              `xorm:"pk autoincr"`
+	SettingKey   string             `xorm:"varchar(255) unique"` // key should be lowercase
+	SettingValue string             `xorm:"text"`
+	Version      int                `xorm:"version"`
+	Created      timeutil.TimeStamp `xorm:"created"`
+	Updated      timeutil.TimeStamp `xorm:"updated"`
+}
+
+// TableName sets the table name for the settings struct
+func (s *Setting) TableName() string {
+	return "system_setting"
+}
+
+func MigrateIniToDatabase(x *xorm.Engine) error {
+	uiMap, err := util.ConfigSectionToMap(setting.UI, "ui")
+	if err != nil {
+		return err
+	}
+
+	sess := x.NewSession()
+	defer sess.Close()
+
+	if err = sess.Begin(); err != nil {
+		return err
+	}
+
+	_ = GetRevision(sess) // prepare the "revision" key ahead
+
+	_, err = sess.Exec("UPDATE system_setting SET version=version+1 WHERE setting_key=?", keyRevision)
+	if err != nil {
+		return err
+	}
+	for k, v := range uiMap {
+		res, err := sess.Exec("UPDATE system_setting SET version=version+1, setting_value=? WHERE setting_key=?", v, k)
+		if err != nil {
+			return err
+		}
+		rows, _ := res.RowsAffected()
+		if rows == 0 { // if no existing row, insert a new row
+			if _, err = sess.Insert(&system_model.Setting{SettingKey: k, SettingValue: v}); err != nil {
+				return err
+			}
+		}
+	}
+
+	return sess.Commit()
+}
+
+func GetRevision(sess *xorm.Session) int {
+	revision := &Setting{}
+	exist, err := sess.Where("setting_key = ?", keyRevision).Get(revision)
+	if err != nil {
+		return 0
+	} else if !exist {
+		_, err = sess.Insert(&Setting{SettingKey: keyRevision, Version: 1})
+		if err != nil {
+			return 0
+		}
+		return 1
+	}
+
+	if revision.Version <= 0 || revision.Version >= math.MaxInt-1 {
+		_, err = sess.Exec("UPDATE system_setting SET version=1 WHERE setting_key=?", keyRevision)
+		if err != nil {
+			return 0
+		}
+		return 1
+	}
+	return revision.Version
+}

modules/util/util.go

@@ -6,8 +6,10 @@ package util
 import (
 	"bytes"
 	"crypto/rand"
+	"encoding/json"
 	"fmt"
 	"math/big"
+	"reflect"
 	"strconv"
 	"strings"
 
@@ -257,3 +259,38 @@ func ReserveLineBreakForTextarea(input string) string {
 	// Other than this, we should respect the original content, even leading or trailing spaces.
 	return strings.ReplaceAll(input, "\r\n", "\n")
 }
+
+func ConfigSectionToMap(in any, keyPrefix string) (map[string]string, error) {
+	if keyPrefix == "" {
+		return nil, fmt.Errorf("keyPrefix is empty")
+	}
+	out := map[string]string{}
+
+	v := reflect.ValueOf(in)
+	if v.Kind() == reflect.Ptr {
+		v = v.Elem()
+	}
+	if v.Kind() != reflect.Struct {
+		return nil, fmt.Errorf("in is not a struct")
+	}
+
+	t := v.Type()
+	for i := 0; i < v.NumField(); i++ {
+		fi := t.Field(i)
+		if tagValue := fi.Tag.Get("ini"); tagValue == "-" {
+			continue
+		}
+		switch v.FieldByName(fi.Name).Kind() {
+		case reflect.Bool,
+			reflect.String,
+			reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64,
+			reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
+			out[fmt.Sprintf("%s.%s", keyPrefix, ToSnakeCase(fi.Name))] = fmt.Sprintf("%v", v.FieldByName(fi.Name).Interface())
+		case reflect.Slice, reflect.Array:
+			str, _ := json.Marshal(v.FieldByName(fi.Name))
+			out[fmt.Sprintf("%s.%s", keyPrefix, ToSnakeCase(fi.Name))] = string(str)
+		}
+	}
+
+	return out, nil
+}

options/locale/locale_en-US.ini

@@ -3360,6 +3360,26 @@ config.picture_service = Picture Service
 config.disable_gravatar = Disable Gravatar
 config.enable_federated_avatar = Enable Federated Avatars
 config.open_with_editor_app_help = The "Open with" editors for the clone menu. If left empty, the default will be used. Expand to see the default.
+config.ui.explore_paging_num = Explore Paging Number
+config.ui.issue_paging_num = Issue Paging Number
+config.ui.feed_max_commit_numb = Feed Max Commit Number
+config.ui.feed_paging_num = Feed Paging Number
+config.ui.sitemap_paging_num = Sitemap Paging Number
+config.ui.graph_max_commit_num = Graph Max Commit Number
+config.ui.code_comment_lines = Code Comment Lines
+config.ui.max_display_file_size = Max Display File Size
+config.ui.default_theme = Default Theme
+config.ui.themes = Themes
+config.ui.reactions = Reactions
+config.ui.reaction_max_user_num = Reaction Max User Number
+config.ui.custom_emojis = Custom Emojis
+config.ui.explore_paging_default_sort = Explore Paging Default Sort
+config.ui.ambiguous_unicode_detection = Ambiguous Unicode Detection
+config.ui.show_user_email = Show User Email
+config.ui.default_show_full_name = Default Show Full Name
+config.ui.search_repo_description = Search Repo Description
+config.ui.only_show_relevant_repos = Only Show Relevant Repos
+config.ui.preferred_timestamp_tense = Preferred Timestamp Tense
 
 config.git_config = Git Configuration
 config.git_disable_diff_highlight = Disable Diff Syntax Highlight

routers/web/admin/config.go

@@ -19,7 +19,9 @@ import (
 	"code.gitea.io/gitea/modules/setting/config"
 	"code.gitea.io/gitea/modules/templates"
 	"code.gitea.io/gitea/modules/util"
+	"code.gitea.io/gitea/modules/web"
 	"code.gitea.io/gitea/services/context"
+	"code.gitea.io/gitea/services/forms"
 	"code.gitea.io/gitea/services/mailer"
 
 	"gitea.com/go-chi/session"
@@ -191,6 +193,7 @@ func ConfigSettings(ctx *context.Context) {
 	ctx.Data["Title"] = ctx.Tr("admin.config_settings")
 	ctx.Data["PageIsAdminConfig"] = true
 	ctx.Data["PageIsAdminConfigSettings"] = true
+	ctx.Data["UI"] = setting.UI
 	ctx.Data["DefaultOpenWithEditorAppsString"] = setting.DefaultOpenWithEditorApps().ToTextareaString()
 	ctx.HTML(http.StatusOK, tplConfigSettings)
 }
@@ -253,3 +256,22 @@ func ChangeConfig(ctx *context.Context) {
 	config.GetDynGetter().InvalidateCache()
 	ctx.JSONOK()
 }
+
+func ChangeUIConfig(ctx *context.Context) {
+	form := web.GetForm(ctx).(*forms.UIForm)
+	formMap, err := util.ConfigSectionToMap(form, "ui")
+	if err != nil {
+		ctx.ServerError("unable convert struct to map[string]string", err)
+		return
+	}
+
+	log.Debug("ChangeUIConfig form: %+v", formMap)
+
+	if err = system_model.SetSettings(ctx, formMap); err != nil {
+		log.Error("set ui configuration failed: %v", err)
+		ctx.ServerError("SetSettings", err)
+		return
+	}
+
+	ctx.Redirect(setting.AppSubURL + "/-/admin/config/settings")
+}

routers/web/web.go

@@ -720,6 +720,7 @@ func registerRoutes(m *web.Router) {
 		m.Group("/config", func() {
 			m.Get("", admin.Config)
 			m.Post("", admin.ChangeConfig)
+			m.Post("/ui", web.Bind(forms.UIForm{}), admin.ChangeUIConfig)
 			m.Post("/test_mail", admin.SendTestMail)
 			m.Post("/test_cache", admin.TestCache)
 			m.Get("/settings", admin.ConfigSettings)

services/forms/admin_config_form.go

@@ -0,0 +1,42 @@
+package forms
+
+import (
+	"net/http"
+
+	"code.gitea.io/gitea/modules/web/middleware"
+	"code.gitea.io/gitea/services/context"
+	"gitea.com/go-chi/binding"
+)
+
+type UIForm struct {
+	ExplorePagingNum        int
+	SitemapPagingNum        int
+	IssuePagingNum          int
+	RepoSearchPagingNum     int
+	MembersPagingNum        int
+	FeedMaxCommitNum        int
+	FeedPagingNum           int
+	PackagesPagingNum       int
+	GraphMaxCommitNum       int
+	CodeCommentLines        int
+	ReactionMaxUserNum      int
+	MaxDisplayFileSize      int64
+	ShowUserEmail           bool
+	DefaultShowFullName     bool
+	DefaultTheme            string
+	Themes                  []string
+	Reactions               []string
+	CustomEmojis            []string
+	SearchRepoDescription   bool
+	OnlyShowRelevantRepos   bool
+	ExploreDefaultSort      string `binding:"In(recentupdate,alphabetically,reverselastlogin,newest,oldest)"`
+	PreferredTimestampTense string `binding:"In(mixed,absolute)"`
+
+	AmbiguousUnicodeDetection bool
+}
+
+// Validate validates fields
+func (f *UIForm) Validate(req *http.Request, errs binding.Errors) binding.Errors {
+	ctx := context.GetValidateContext(req)
+	return middleware.Validate(errs, ctx.Data, f, ctx.Locale)
+}