Skip to content

Commit b580b59

Browse files
committed
Fix test
1 parent 43cdc71 commit b580b59

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

services/repository/delete.go

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -188,17 +188,18 @@ func DeleteRepositoryDirectly(ctx context.Context, repoID int64, ignoreOrgTeams
188188
return err
189189
}
190190

191-
// Delete Pulls and related objects
192-
if err := issues_model.DeletePullsByBaseRepoID(ctx, repoID); err != nil {
193-
return err
194-
}
195-
196191
// Delete Issues and related objects
197192
var attachmentPaths []string
198193
if attachmentPaths, err = issue_service.DeleteIssuesByRepoID(ctx, repoID); err != nil {
199194
return err
200195
}
201196

197+
// Delete Pulls and related objects
198+
// Notice: we should delete issue first because issue may load pull request
199+
if err := issues_model.DeletePullsByBaseRepoID(ctx, repoID); err != nil {
200+
return err
201+
}
202+
202203
// Delete issue index
203204
if err := db.DeleteResourceIndex(ctx, "issue_index", repoID); err != nil {
204205
return err

0 commit comments

Comments
 (0)