fix: simplify name check

ahanoff · ahanoff · commit b9dcca117ece · 2025-09-07T18:09:12.000+08:00
diff --git a/modules/packages/swift/metadata.go b/modules/packages/swift/metadata.go
@@ -191,8 +191,8 @@ func ParsePackage(sr io.ReaderAt, size int64, mr io.Reader) (*Package, error) {
 			MiddleName: ssc.Author.MiddleName,
 			FamilyName: ssc.Author.FamilyName,
 		}
-		// If Name is not provided but individual name components are, generate it
-		if author.Name == "" && (author.GivenName != "" || author.MiddleName != "" || author.FamilyName != "") {
+		// If Name is not provided, generate it from individual name components
+		if author.Name == "" {
 			author.Name = author.String()
 		}
 		p.Metadata.Author = author

Original file line number	Diff line number	Diff line change
`@@ -191,8 +191,8 @@ func ParsePackage(sr io.ReaderAt, size int64, mr io.Reader) (*Package, error) {`
`191`	`191`	`MiddleName: ssc.Author.MiddleName,`
`192`	`192`	`FamilyName: ssc.Author.FamilyName,`
`193`	`193`	`}`
`194`		`- // If Name is not provided but individual name components are, generate it`
`195`		`- if author.Name == "" && (author.GivenName != "" \|\| author.MiddleName != "" \|\| author.FamilyName != "") {`
	`194`	`+ // If Name is not provided, generate it from individual name components`
	`195`	`+ if author.Name == "" {`
`196`	`196`	`author.Name = author.String()`
`197`	`197`	`}`
`198`	`198`	`p.Metadata.Author = author`