fix: quote date range arguments for robust CLI parsing

appleboy · appleboy · commit bc35baf25555 · 2025-05-18T23:12:07.000+08:00
- Quote the values for --since and --until options to handle arguments containing spaces or special characters

Signed-off-by: appleboy &lt;appleboy.tw@gmail.com&gt;
diff --git a/modules/git/repo_commit.go b/modules/git/repo_commit.go
@@ -241,10 +241,10 @@ func (repo *Repository) CommitsByFileAndRange(opts CommitsByFileAndRangeOptions)
 			gitCmd.AddOptionValues("--not", opts.Not)
 		}
 		if opts.Since != "" {
-			gitCmd.AddOptionFormat("--since=%s", opts.Since)
+			gitCmd.AddOptionFormat("--since='%s'", opts.Since)
 		}
 		if opts.Until != "" {
-			gitCmd.AddOptionFormat("--until=%s", opts.Until)
+			gitCmd.AddOptionFormat("--until='%s'", opts.Until)
 		}
 
 		gitCmd.AddDashesAndList(opts.File)

Original file line number	Diff line number	Diff line change
`@@ -241,10 +241,10 @@ func (repo *Repository) CommitsByFileAndRange(opts CommitsByFileAndRangeOptions)`
`241`	`241`	`gitCmd.AddOptionValues("--not", opts.Not)`
`242`	`242`	`}`
`243`	`243`	`if opts.Since != "" {`
`244`		`- gitCmd.AddOptionFormat("--since=%s", opts.Since)`
	`244`	`+ gitCmd.AddOptionFormat("--since='%s'", opts.Since)`
`245`	`245`	`}`
`246`	`246`	`if opts.Until != "" {`
`247`		`- gitCmd.AddOptionFormat("--until=%s", opts.Until)`
	`247`	`+ gitCmd.AddOptionFormat("--until='%s'", opts.Until)`
`248`	`248`	`}`
`249`	`249`
`250`	`250`	`gitCmd.AddDashesAndList(opts.File)`