fix commented state

Author: lunny

modules/migrations/base/review.go

@@ -8,10 +8,10 @@ import "time"
 
 // enumerate all review states
 const (
-	ReviewStatePending        = "PENDING"
-	ReviewStateApproved       = "APPROVED"
-	ReviewStateRequestChanges = "CHANGES_REQUESTED"
-	ReviewStateComment        = "COMMENT"
+	ReviewStatePending          = "PENDING"
+	ReviewStateApproved         = "APPROVED"
+	ReviewStateChangesRequested = "CHANGES_REQUESTED"
+	ReviewStateCommented        = "COMMENTED"
 )
 
 // Review is a standard review information

modules/migrations/gitea.go

@@ -716,9 +716,9 @@ func convertReviewState(state string) models.ReviewType {
 		return models.ReviewTypePending
 	case base.ReviewStateApproved:
 		return models.ReviewTypeApprove
-	case base.ReviewStateRequestChanges:
+	case base.ReviewStateChangesRequested:
 		return models.ReviewTypeReject
-	case base.ReviewStateComment:
+	case base.ReviewStateCommented:
 		return models.ReviewTypeComment
 	default:
 		return models.ReviewTypePending

modules/migrations/github_test.go

@@ -426,8 +426,30 @@ func TestGitHubDownloadRepo(t *testing.T) {
 			ReviewerName: "lunny",
 			CommitID:     "2be9101c543658591222acbee3eb799edfc3853d",
 			CreatedAt:    time.Date(2020, 01, 04, 06, 07, 06, 0, time.UTC),
-			State:        base.ReviewStateRequestChanges,
+			State:        base.ReviewStateChangesRequested,
 			Content:      "Don't add more reviews",
 		},
+		{
+			ID:           338349019,
+			IssueIndex:   4,
+			ReviewerID:   81045,
+			ReviewerName: "lunny",
+			CommitID:     "2be9101c543658591222acbee3eb799edfc3853d",
+			CreatedAt:    time.Date(2020, 01, 04, 11, 21, 41, 0, time.UTC),
+			State:        base.ReviewStateCommented,
+			Comments: []*base.ReviewComment{
+				{
+					ID:        363029944,
+					Content:   "test a single comment.",
+					TreePath:  "LICENSE",
+					Position:  4,
+					CommitID:  "2be9101c543658591222acbee3eb799edfc3853d",
+					PosterID:  81045,
+					Reactions: &base.Reactions{},
+					CreatedAt: time.Date(2020, 01, 04, 11, 21, 41, 0, time.UTC),
+					UpdatedAt: time.Date(2020, 01, 04, 11, 21, 41, 0, time.UTC),
+				},
+			},
+		},
 	}, reviews)
 }