Skip to content

Commit c483419

Browse files
Better styling for code review comment form (#11413)
Co-authored-by: techknowlogick <[email protected]>
1 parent db87e91 commit c483419

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

templates/repo/diff/section_unified.tmpl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@
2828
{{$isNotPending := (not (eq (index $line.Comments 0).Review.Type 0))}}
2929
<tr>
3030
<td colspan="2" class="lines-num"></td>
31-
<td class="lines-type-marker"></td>
32-
<td class="add-comment-left add-comment-right">
31+
<td class="add-comment-left add-comment-right" colspan="2">
3332
{{if $resolved}}
3433
<div class = "ui attached header">
3534
<span class="ui grey text left"><b>{{$resolveDoer.Name}}</b> {{$.root.i18n.Tr "repo.issues.review.resolved_by"}}</span>

web_src/js/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1242,7 +1242,7 @@ function initPullRequestReview() {
12421242
if (!ntr.hasClass('add-comment')) {
12431243
ntr = $(`<tr class="add-comment">${
12441244
isSplit ? '<td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-left"></td><td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-right"></td>' :
1245-
'<td class="lines-num"></td><td class="lines-num"></td><td class="lines-type-marker"></td><td class="add-comment-left add-comment-right"></td>'
1245+
'<td class="lines-num"></td><td class="lines-num"></td><td class="add-comment-left add-comment-right" colspan="2"></td>'
12461246
}</tr>`);
12471247
tr.after(ntr);
12481248
}

web_src/less/_review.less

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,13 @@
7474
margin-top: 0;
7575
}
7676

77+
.comment-list {
78+
padding-bottom: 10px;
79+
}
80+
7781
.footer {
7882
border-top: 1px solid #f1f1f1;
79-
margin-top: 10px;
83+
padding: 10px 0 10px 0;
8084

8185
.markdown-info {
8286
display: inline-block;
@@ -101,7 +105,7 @@
101105
}
102106

103107
form.comment-form-reply {
104-
margin: 0 0 0 4em;
108+
margin: 0 0 0 1em;
105109
}
106110
}
107111

0 commit comments

Comments
 (0)