more code comment info and cleanup

Author: 6543

routers/web/repo/view.go

@@ -722,7 +722,6 @@ func checkHomeCodeViewable(ctx *context.Context) {
 			}
 		}
 
-		// TODO: ctx.Repo.Repository.DefaultUnit has to be respected here ... but we need to let code unit have it's own subpath ...
 		var firstUnit *unit_model.Unit
 		for _, repoUnitType := range ctx.Repo.Permission.ReadableUnitTypes() {
 			if repoUnitType == unit_model.TypeCode {
@@ -773,7 +772,7 @@ func checkCitationFile(ctx *context.Context, entry *git.TreeEntry) {
 	}
 }
 
-// HomeWithFeedCheck render repository home page or return feed
+// HomeWithFeedCheck redirect to default unit or return feed
 func HomeWithFeedCheck(ctx *context.Context) {
 	if setting.Other.EnableFeed {
 		isFeed, _, showFeedType := feed.GetFeedType(ctx.PathParam(":reponame"), ctx.Req)
@@ -794,11 +793,11 @@ func HomeWithFeedCheck(ctx *context.Context) {
 	if defaultURI == "/" { // support legacy code units
 		defaultURI = "/code"
 	}
-	ctx.Redirect(ctx.Repo.RepoLink + defaultURI)
+	ctx.Redirect(ctx.Repo.RepoLink+defaultURI, http.StatusMovedPermanently)
 }
 
-// Home render repository home page
-func Home(ctx *context.Context) {
+// CodeHome render repository home page
+func CodeHome(ctx *context.Context) {
 	checkHomeCodeViewable(ctx)
 	if ctx.Written() {
 		return

routers/web/web.go

@@ -1139,9 +1139,10 @@ func registerRoutes(m *web.Router) {
 	)
 	// end "/{username}/{reponame}/settings"
 
-	// user/org home, including rss feeds
+	// user/org home, witch either redirects to default unit or return rss feeds
 	m.Get("/{username}/{reponame}", ignSignIn, context.RepoAssignment, context.RepoRef(), repo.SetEditorconfigIfExists, repo.HomeWithFeedCheck)
-	m.Get("/{username}/{reponame}/code", ignSignIn, context.RepoAssignment, context.RepoRef(), repo.SetEditorconfigIfExists, repo.Home)
+	// show the code unit's home view
+	m.Get("/{username}/{reponame}/code", ignSignIn, context.RepoAssignment, context.RepoRef(), repo.SetEditorconfigIfExists, repo.CodeHome)
 
 	// TODO: maybe it should relax the permission to allow "any access"
 	m.Post("/{username}/{reponame}/markup", ignSignIn, context.RepoAssignment, context.RequireRepoReaderOr(unit.TypeCode, unit.TypeIssues, unit.TypePullRequests, unit.TypeReleases, unit.TypeWiki), web.Bind(structs.MarkupOption{}), misc.Markup)