improvements

Author: lunny

models/repo/wiki_test.go

@@ -9,7 +9,6 @@ import (
 
 	repo_model "code.gitea.io/gitea/models/repo"
 	"code.gitea.io/gitea/models/unittest"
-	"code.gitea.io/gitea/modules/gitrepo"
 	"code.gitea.io/gitea/modules/setting"
 
 	"github.com/stretchr/testify/assert"
@@ -36,16 +35,3 @@ func TestRepository_WikiPath(t *testing.T) {
 	expected := filepath.Join(setting.RepoRootPath, "user2/repo1.wiki.git")
 	assert.Equal(t, expected, repo.WikiPath())
 }
-
-func TestRepository_HasWiki(t *testing.T) {
-	unittest.PrepareTestEnv(t)
-	repo1 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
-	exist, err := gitrepo.IsRepositoryExist(t.Context(), repo1.WikiStorageRepo())
-	assert.NoError(t, err)
-	assert.True(t, exist)
-
-	repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
-	exist, err = gitrepo.IsRepositoryExist(t.Context(), repo2.WikiStorageRepo())
-	assert.NoError(t, err)
-	assert.False(t, exist)
-}

services/wiki/wiki.go

@@ -36,6 +36,7 @@ func getWikiWorkingLockKey(repoID int64) string {
 // InitWiki initializes a wiki for repository,
 // it does nothing when repository already has wiki.
 func InitWiki(ctx context.Context, repo *repo_model.Repository) error {
+	// don't use HasWiki because the error should not be ignored.
 	if exist, err := gitrepo.IsRepositoryExist(ctx, repo.WikiStorageRepo()); err != nil {
 		return err
 	} else if exist {