Skip to content

Commit c71d872

Browse files
committed
add more comments
1 parent c11b896 commit c71d872

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

modules/ssh/ssh.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,11 @@ func getExitStatusFromError(err error) int {
7474
return waitStatus.ExitStatus()
7575
}
7676

77+
// sessionPartial is the private struct from "gliderlabs/ssh/session.go"
78+
// we need to read the original "conn" field from "ssh.Session interface" which contains the "*session pointer"
79+
// https://github.com/gliderlabs/ssh/blob/d137aad99cd6f2d9495bfd98c755bec4e5dffb8c/session.go#L109-L113
80+
// If upstream fixes the problem and/or changes the struct, we need to follow.
81+
// If the struct mismatches, the builtin ssh server will fail during integration tests.
7782
type sessionPartial struct {
7883
sync.Mutex
7984
gossh.Channel

0 commit comments

Comments
 (0)