refactor(actions): verify workflow file with actionlint

Author: TheFox0x7

modules/actions/jobparser/model.go

@@ -206,43 +206,6 @@ func (evt *Event) Inputs() []WorkflowDispatchInput {
 	return evt.inputs
 }
 
-func parseWorkflowDispatchInputs(inputs map[string]interface{}) ([]WorkflowDispatchInput, error) {
-	var results []WorkflowDispatchInput
-	for name, input := range inputs {
-		inputMap, ok := input.(map[string]interface{})
-		if !ok {
-			return nil, fmt.Errorf("invalid input: %v", input)
-		}
-		input := WorkflowDispatchInput{
-			Name: name,
-		}
-		if desc, ok := inputMap["description"].(string); ok {
-			input.Description = desc
-		}
-		if required, ok := inputMap["required"].(bool); ok {
-			input.Required = required
-		}
-		if defaultVal, ok := inputMap["default"].(string); ok {
-			input.Default = defaultVal
-		}
-		if inputType, ok := inputMap["type"].(string); ok {
-			input.Type = inputType
-		}
-		if options, ok := inputMap["options"].([]string); ok {
-			input.Options = options
-		} else if options, ok := inputMap["options"].([]interface{}); ok {
-			for _, option := range options {
-				if opt, ok := option.(string); ok {
-					input.Options = append(input.Options, opt)
-				}
-			}
-		}
-
-		results = append(results, input)
-	}
-	return results, nil
-}
-
 // Helper to convert actionlint errors
 func acErrToError(acErrs []*actionlint.Error) []error {
 	errs := make([]error, len(acErrs))
@@ -339,6 +302,16 @@ func GetEventsFromContent(content []byte) ([]*Event, error) {
 	return events, nil
 }
 
+func ValidateWorkflow(content []byte) error {
+	_, errs := actionlint.Parse(content)
+	err := make([]error, len(errs))
+	for _, e := range errs {
+		err = append(err, fmt.Errorf("%d:%d: %s", e.Line, e.Column, e.Message))
+	}
+	return errors.Join(err...)
+
+}
+
 // parseMappingNode parse a mapping node and preserve order.
 func parseMappingNode[T any](node *yaml.Node) ([]string, []T, error) {
 	if node.Kind != yaml.MappingNode {

routers/web/repo/view_file.go

@@ -17,6 +17,7 @@ import (
 	"code.gitea.io/gitea/models/renderhelper"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/actions"
+	"code.gitea.io/gitea/modules/actions/jobparser"
 	"code.gitea.io/gitea/modules/charset"
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/highlight"
@@ -27,8 +28,6 @@ import (
 	"code.gitea.io/gitea/services/context"
 	issue_service "code.gitea.io/gitea/services/issue"
 	files_service "code.gitea.io/gitea/services/repository/files"
-
-	"github.com/nektos/act/pkg/model"
 )
 
 func prepareToRenderFile(ctx *context.Context, entry *git.TreeEntry) {
@@ -75,7 +74,7 @@ func prepareToRenderFile(ctx *context.Context, entry *git.TreeEntry) {
 		if err != nil {
 			log.Error("actions.GetContentFromEntry: %v", err)
 		}
-		_, workFlowErr := model.ReadWorkflow(bytes.NewReader(content))
+		workFlowErr := jobparser.ValidateWorkflow(content)
 		if workFlowErr != nil {
 			ctx.Data["FileError"] = ctx.Locale.Tr("actions.runs.invalid_workflow_helper", workFlowErr.Error())
 		}