fix

Author: wxiaoguang

models/unittest/fixtures.go

@@ -4,15 +4,12 @@
 package unittest
 
 import (
-	"fmt"
-
 	"code.gitea.io/gitea/models/db"
 	"code.gitea.io/gitea/modules/auth/password/hash"
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/util"
 
 	"xorm.io/xorm"
-	"xorm.io/xorm/schemas"
 )
 
 var defaultFixturesLoader *fixturesLoader
@@ -32,47 +29,7 @@ func InitFixtures(opts FixturesOptions, engine ...*xorm.Engine) (err error) {
 	return err
 }
 
-func loadFixtureResetSeqPgsql(e *xorm.Engine) error {
-	results, err := e.QueryString(`SELECT 'SELECT SETVAL(' ||
-		quote_literal(quote_ident(PGT.schemaname) || '.' || quote_ident(S.relname)) ||
-		', COALESCE(MAX(' ||quote_ident(C.attname)|| '), 1) ) FROM ' ||
-		quote_ident(PGT.schemaname)|| '.'||quote_ident(T.relname)|| ';'
-	 FROM pg_class AS S,
-	      pg_depend AS D,
-	      pg_class AS T,
-	      pg_attribute AS C,
-	      pg_tables AS PGT
-	 WHERE S.relkind = 'S'
-	     AND S.oid = D.objid
-	     AND D.refobjid = T.oid
-	     AND D.refobjid = C.attrelid
-	     AND D.refobjsubid = C.attnum
-	     AND T.relname = PGT.tablename
-	 ORDER BY S.relname;`)
-	if err != nil {
-		return fmt.Errorf("failed to generate sequence update: %w", err)
-	}
-	for _, r := range results {
-		for _, value := range r {
-			_, err = e.Exec(value)
-			if err != nil {
-				return fmt.Errorf("failed to update sequence: %s, error: %w", value, err)
-			}
-		}
-	}
-	return nil
-}
-
 // LoadFixtures load fixtures for a test database
 func LoadFixtures() error {
-	if err := defaultFixturesLoader.Load(); err != nil {
-		return err
-	}
-	// Now if we're running postgres we need to tell it to update the sequences
-	if defaultFixturesLoader.engine.Dialect().URI().DBType == schemas.POSTGRES {
-		if err := loadFixtureResetSeqPgsql(defaultFixturesLoader.engine); err != nil {
-			return err
-		}
-	}
-	return nil
+	return defaultFixturesLoader.Load()
 }

models/unittest/fixtures_loader.go

@@ -31,6 +31,7 @@ func (f *fixturesLoader) prepareFieldValue(v any) any {
 	}
 	return v
 }
+
 func (f *fixturesLoader) loadFixtures(file string) error {
 	data, err := os.ReadFile(file)
 	if err != nil {
@@ -51,9 +52,9 @@ func (f *fixturesLoader) loadFixtures(file string) error {
 
 	switch f.engine.Dialect().URI().DBType {
 	case schemas.MSSQL:
-		_, _ = f.engine.Exec("SET IDENTITY_INSERT [%s] ON", tableName)
+		_, _ = f.engine.Exec(fmt.Sprintf("SET IDENTITY_INSERT `%s` ON", tableName))
 		defer func() {
-			_, _ = f.engine.Exec("SET IDENTITY_INSERT [%s] OFF", tableName)
+			_, _ = f.engine.Exec(fmt.Sprintf("SET IDENTITY_INSERT `%s` OFF", tableName))
 		}()
 	}