remove active runner deletion blocker

* translation text would be defect due to this change

Author: ChristopherHX

options/locale/locale_en-US.ini

@@ -3761,7 +3761,6 @@ runners.update_runner_failed = Failed to update runner
 runners.delete_runner = Delete this runner
 runners.delete_runner_success = Runner deleted successfully
 runners.delete_runner_failed = Failed to delete runner
-runners.delete_runner_failed_runner_active = Failed to delete active runner
 runners.delete_runner_header = Confirm to delete this runner
 runners.delete_runner_notice = If a task is running on this runner, it will be terminated and mark as failed. It may break building workflow.
 runners.none = No runners available

routers/api/v1/shared/runners.go

@@ -14,8 +14,6 @@ import (
 	"code.gitea.io/gitea/routers/api/v1/utils"
 	"code.gitea.io/gitea/services/context"
 	"code.gitea.io/gitea/services/convert"
-
-	"xorm.io/builder"
 )
 
 // RegistrationToken is response related to registration token
@@ -82,15 +80,6 @@ func DeleteRunner(ctx *context.APIContext, ownerID, repoID, runnerID int64) {
 		ctx.APIErrorNotFound("No permission to delete this runner")
 		return
 	}
-	exist, err := db.Exist[actions_model.ActionTask](ctx, builder.Eq{"`runner_id`": runner.ID}.And(builder.In("`status`", actions_model.StatusWaiting, actions_model.StatusRunning, actions_model.StatusBlocked)))
-	if err != nil {
-		ctx.APIErrorInternal(err)
-		return
-	}
-	if exist {
-		ctx.APIError(http.StatusConflict, "Runner is active")
-		return
-	}
 
 	err = actions_model.DeleteRunner(ctx, runner.ID)
 	if err != nil {

routers/web/shared/actions/runners.go

@@ -18,8 +18,6 @@ import (
 	shared_user "code.gitea.io/gitea/routers/web/shared/user"
 	"code.gitea.io/gitea/services/context"
 	"code.gitea.io/gitea/services/forms"
-
-	"xorm.io/builder"
 )
 
 const (
@@ -317,22 +315,6 @@ func RunnerDeletePost(ctx *context.Context) {
 	successRedirectTo := rCtx.RedirectLink
 	failedRedirectTo := rCtx.RedirectLink + url.PathEscape(ctx.PathParam("runnerid"))
 
-	exist, err := db.Exist[actions_model.ActionTask](ctx, builder.Eq{"`runner_id`": runner.ID}.And(builder.In("`status`", actions_model.StatusWaiting, actions_model.StatusRunning, actions_model.StatusBlocked)))
-	if err != nil {
-		log.Warn("DeleteRunnerPost.Exist failed: %v, url: %s", err, ctx.Req.URL)
-		ctx.Flash.Warning(ctx.Tr("actions.runners.delete_runner_failed"))
-
-		ctx.JSONRedirect(failedRedirectTo)
-		return
-	}
-	if exist {
-		log.Warn("DeleteRunnerPost.Exist failed: cannot delete active runner")
-		ctx.Flash.Warning(ctx.Tr("actions.runners.delete_runner_failed_runner_active"))
-
-		ctx.JSONRedirect(failedRedirectTo)
-		return
-	}
-
 	if err := actions_model.DeleteRunner(ctx, runner.ID); err != nil {
 		log.Warn("DeleteRunnerPost.UpdateRunner failed: %v, url: %s", err, ctx.Req.URL)
 		ctx.Flash.Warning(ctx.Tr("actions.runners.delete_runner_failed"))

tests/integration/api_org_runner_test.go

@@ -123,22 +123,6 @@ func TestAPIRunnerDeleteAdminRunnerNotFoundOrgApi(t *testing.T) {
 	MakeRequest(t, req, http.StatusNotFound)
 }
 
-func TestAPIRunnerDeleteConflictWhileJobIsRunningOrgApi(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
-	userUsername := "user2"
-	token := getUserToken(t, userUsername, auth_model.AccessTokenScopeWriteOrganization)
-
-	_, err := db.GetEngine(t.Context()).Insert(&actions_model.ActionTask{
-		RunnerID: 34347,
-		Status:   actions_model.StatusRunning,
-	})
-	assert.NoError(t, err)
-
-	// Verify delete the runner by id is blocked by active job
-	req := NewRequest(t, "DELETE", fmt.Sprintf("/api/v1/orgs/org3/actions/runners/%d", 34347)).AddTokenAuth(token)
-	MakeRequest(t, req, http.StatusConflict)
-}
-
 func TestAPIRunnerDeleteNoConflictWhileJobIsDoneOrgApi(t *testing.T) {
 	defer tests.PrepareTestEnv(t)()
 	userUsername := "user2"