fix list endpoint response / add TestWorkflowApi

* uses all endpoints added here
* checks if disabled workflows cannot dispatch
* remove node_id
* fix path field
* test that the URL field of the workflow result is usable
* additional test for non default branch workflow
* return 200 when no workflows found, with an empty list

Author: ChristopherHX

modules/structs/repo_actions.go

@@ -45,11 +45,10 @@ type CreateActionWorkflowDispatch struct {
 
 // ActionWorkflow represents a ActionWorkflow
 type ActionWorkflow struct {
-	ID     string `json:"id"`
-	NodeID string `json:"node_id"`
-	Name   string `json:"name"`
-	Path   string `json:"path"`
-	State  string `json:"state"`
+	ID    string `json:"id"`
+	Name  string `json:"name"`
+	Path  string `json:"path"`
+	State string `json:"state"`
 	// swagger:strfmt date-time
 	CreatedAt time.Time `json:"created_at"`
 	// swagger:strfmt date-time
@@ -58,7 +57,7 @@ type ActionWorkflow struct {
 	HTMLURL   string    `json:"html_url"`
 	BadgeURL  string    `json:"badge_url"`
 	// swagger:strfmt date-time
-	DeletedAt time.Time `json:"deleted_at"`
+	DeletedAt time.Time `json:"deleted_at,omitempty"`
 }
 
 // ActionWorkflowResponse returns a ActionWorkflow

routers/api/v1/repo/action.go

@@ -630,13 +630,7 @@ func (a ActionWorkflow) ListRepositoryWorkflows(ctx *context.APIContext) {
 		return
 	}
 
-	if len(workflows) == 0 {
-		ctx.Error(http.StatusNotFound, "ListActionWorkflows", err)
-		return
-	}
-
-	ctx.SetTotalCountHeader(int64(len(workflows)))
-	ctx.JSON(http.StatusOK, workflows)
+	ctx.JSON(http.StatusOK, &api.ActionWorkflowResponse{Workflows: workflows, TotalCount: int64(len(workflows))})
 }
 
 func (a ActionWorkflow) GetWorkflow(ctx *context.APIContext) {

services/actions/workflow.go

@@ -6,7 +6,7 @@ package actions
 import (
 	"fmt"
 	"net/http"
-	"os"
+	"path"
 	"strings"
 
 	actions_model "code.gitea.io/gitea/models/actions"
@@ -53,14 +53,14 @@ func getActionWorkflowPath(commit *git.Commit) string {
 	return ""
 }
 
-func getActionWorkflowEntry(ctx *context.APIContext, commit *git.Commit, entry *git.TreeEntry) *api.ActionWorkflow {
+func getActionWorkflowEntry(ctx *context.APIContext, commit *git.Commit, folder string, entry *git.TreeEntry) *api.ActionWorkflow {
 	cfgUnit := ctx.Repo.Repository.MustGetUnit(ctx, unit.TypeActions)
 	cfg := cfgUnit.ActionsConfig()
 
 	defaultBranch, _ := commit.GetBranchName()
 
 	URL := fmt.Sprintf("%s/actions/workflows/%s", ctx.Repo.Repository.APIURL(), entry.Name())
-	HTMLURL := fmt.Sprintf("%s/src/branch/%s/%s/%s", ctx.Repo.Repository.HTMLURL(ctx), defaultBranch, getActionWorkflowPath(commit), entry.Name())
+	HTMLURL := fmt.Sprintf("%s/src/branch/%s/%s/%s", ctx.Repo.Repository.HTMLURL(ctx), defaultBranch, folder, entry.Name())
 	badgeURL := fmt.Sprintf("%s/actions/workflows/%s/badge.svg?branch=%s", ctx.Repo.Repository.HTMLURL(ctx), entry.Name(), ctx.Repo.Repository.DefaultBranch)
 
 	// See https://docs.github.com/en/rest/actions/workflows?apiVersion=2022-11-28#get-a-workflow
@@ -75,13 +75,6 @@ func getActionWorkflowEntry(ctx *context.APIContext, commit *git.Commit, entry *
 		state = "disabled_manually"
 	}
 
-	// Currently, the NodeID returns the hostname of the server since, as far as I know, Gitea does not have a parameter
-	// similar to an instance ID.
-	hostname, err := os.Hostname()
-	if err != nil {
-		hostname = "unknown"
-	}
-
 	// The CreatedAt and UpdatedAt fields currently reflect the timestamp of the latest commit, which can later be refined
 	// by retrieving the first and last commits for the file history. The first commit would indicate the creation date,
 	// while the last commit would represent the modification date. The DeletedAt could be determined by identifying
@@ -92,9 +85,8 @@ func getActionWorkflowEntry(ctx *context.APIContext, commit *git.Commit, entry *
 
 	return &api.ActionWorkflow{
 		ID:        entry.Name(),
-		NodeID:    hostname,
 		Name:      entry.Name(),
-		Path:      entry.Name(),
+		Path:      path.Join(folder, entry.Name()),
 		State:     state,
 		CreatedAt: createdAt,
 		UpdatedAt: updatedAt,
@@ -135,9 +127,11 @@ func ListActionWorkflows(ctx *context.APIContext) ([]*api.ActionWorkflow, error)
 		return nil, err
 	}
 
+	folder := getActionWorkflowPath(defaultBranchCommit)
+
 	workflows := make([]*api.ActionWorkflow, len(entries))
 	for i, entry := range entries {
-		workflows[i] = getActionWorkflowEntry(ctx, defaultBranchCommit, entry)
+		workflows[i] = getActionWorkflowEntry(ctx, defaultBranchCommit, folder, entry)
 	}
 
 	return workflows, nil