Skip to content

Commit d2142ba

Browse files
authored
Update octicons and use octicon-file-directory-symlink (#25453)
Make use of the [new octicon](primer/octicons#945) that indicates a symlink to a directory: <img width="189" alt="Screenshot 2023-06-22 at 22 50 57" src="https://github.com/go-gitea/gitea/assets/115237/a70690ea-ebfc-48fe-af23-cdc33bcb2098">
1 parent 6281ebf commit d2142ba

File tree

8 files changed

+12
-10
lines changed

8 files changed

+12
-10
lines changed

modules/base/tool.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ func EntryIcon(entry *git.TreeEntry) string {
210210
return "file-symlink-file"
211211
}
212212
if te.IsDir() {
213-
return "file-submodule"
213+
return "file-directory-symlink"
214214
}
215215
return "file-symlink-file"
216216
case entry.IsDir():

package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@github/relative-time-element": "4.3.0",
1414
"@github/text-expander-element": "2.5.0",
1515
"@mcaptcha/vanilla-glue": "0.1.0-alpha-3",
16-
"@primer/octicons": "19.3.0",
16+
"@primer/octicons": "19.4.0",
1717
"@webcomponents/custom-elements": "1.6.0",
1818
"add-asset-webpack-plugin": "2.0.1",
1919
"ansi_up": "5.2.1",

public/img/svg/octicon-copilot-error.svg

Lines changed: 1 addition & 1 deletion
Loading

public/img/svg/octicon-copilot-warning.svg

Lines changed: 1 addition & 1 deletion
Loading

public/img/svg/octicon-file-directory-symlink.svg

Lines changed: 1 addition & 0 deletions
Loading

tests/integration/repo_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ func TestViewRepoWithSymlinks(t *testing.T) {
170170
})
171171
assert.Len(t, items, 5)
172172
assert.Equal(t, "a: svg octicon-file-directory-fill", items[0])
173-
assert.Equal(t, "link_b: svg octicon-file-submodule", items[1])
173+
assert.Equal(t, "link_b: svg octicon-file-directory-symlink", items[1])
174174
assert.Equal(t, "link_d: svg octicon-file-symlink-file", items[2])
175175
assert.Equal(t, "link_hi: svg octicon-file-symlink-file", items[3])
176176
assert.Equal(t, "link_link: svg octicon-file-symlink-file", items[4])

web_src/css/repo.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,8 @@
281281
}
282282

283283
.repository.file.list #repo-files-table tbody .svg.octicon-file,
284-
.repository.file.list #repo-files-table tbody .svg.octicon-file-symlink-file {
284+
.repository.file.list #repo-files-table tbody .svg.octicon-file-symlink-file,
285+
.repository.file.list #repo-files-table tbody .svg.octicon-file-directory-symlink {
285286
color: var(--color-secondary-dark-7);
286287
}
287288

0 commit comments

Comments
 (0)