revert

Author: NorthRealm

options/locale/locale_en-US.ini

@@ -3734,8 +3734,6 @@ deletion.description = Removing a secret is permanent and cannot be undone. Cont
 deletion.success = The secret has been removed.
 deletion.failed = Failed to remove secret.
 edit = Edit secret
-edit.success = The secret has been updated.
-edit.failed = Failed to update secret.
 management = Secrets Management
 
 [actions]

routers/web/shared/secrets/secrets.go

@@ -29,19 +29,14 @@ func SetSecretsContext(ctx *context.Context, ownerID, repoID int64) {
 func PerformSecretsPost(ctx *context.Context, ownerID, repoID int64, redirectURL string) {
 	form := web.GetForm(ctx).(*forms.AddSecretForm)
 
-	s, created, err := secret_service.CreateOrUpdateSecret(ctx, ownerID, repoID, form.Name, util.ReserveLineBreakForTextarea(form.Data), form.Description)
+	s, _, err := secret_service.CreateOrUpdateSecret(ctx, ownerID, repoID, form.Name, util.ReserveLineBreakForTextarea(form.Data), form.Description)
 	if err != nil {
 		log.Error("CreateOrUpdateSecret failed: %v", err)
-		// TODO: secrets.creation.failed and secrets.edit.failed?
 		ctx.JSONError(ctx.Tr("secrets.creation.failed"))
 		return
 	}
 
-	if created {
-		ctx.Flash.Success(ctx.Tr("secrets.creation.success", s.Name))
-	} else {
-		ctx.Flash.Success(ctx.Tr("secrets.edit.success", s.Name))
-	}
+	ctx.Flash.Success(ctx.Tr("secrets.creation.success", s.Name))
 	ctx.JSONRedirect(redirectURL)
 }
 

templates/shared/secrets/add_list.tmpl

@@ -6,7 +6,6 @@
 			data-modal-form.action="{{.Link}}"
 			data-modal-header="{{ctx.Locale.Tr "secrets.creation"}}"
 			data-modal-secret-name.value=""
-			data-modal-secret-name.disabled=""
 			data-modal-secret-data=""
 			data-modal-secret-description=""
 		>
@@ -40,10 +39,9 @@
 				<button class="ui btn interact-bg show-modal tw-p-2"
 					data-modal="#add-secret-modal"
 					data-modal-form.action="{{$.Link}}"
-					data-modal-header="{{ctx.Locale.Tr "secrets.edit"}}"
+					data-modal-header="{{ctx.Locale.Tr "secrets.creation"}}"
 					data-tooltip-content="{{ctx.Locale.Tr "secrets.edit"}}"
 					data-modal-secret-name.value="{{.Name}}"
-					data-modal-secret-name.disabled="true"
 					data-modal-secret-data=""
 					data-modal-secret-description="{{if .Description}}{{.Description}}{{end}}"
 				>