Remove cleanup temp dirs

Author: lunny

cmd/web.go

@@ -166,7 +166,6 @@ func serveInstall(ctx *cli.Context) error {
 func serveInstalled(ctx *cli.Context) error {
 	setting.InitCfgProvider(setting.CustomConf)
 	setting.LoadCommonSettings()
-	setting.CleanUpTempDirs()
 	setting.MustInstalled()
 
 	showWebStartupMessage("Prepare to run web server")

models/unittest/testdb.go

@@ -51,7 +51,6 @@ func InitSettings() {
 	}
 	setting.InitCfgProvider(setting.CustomConf)
 	setting.LoadCommonSettings()
-	setting.CleanUpTempDirs()
 
 	if err := setting.PrepareAppDataPath(); err != nil {
 		log.Fatal("Can not prepare APP_DATA_PATH: %v", err)

modules/base/tool_test.go

@@ -54,7 +54,6 @@ func TestVerifyTimeLimitCode(t *testing.T) {
 JWT_SECRET = %s
 `, secret))
 		setting.LoadCommonSettings()
-		setting.CleanUpTempDirs()
 	}
 
 	initGeneralSecret("KZb_QLUd4fYVyxetjxC4eZkrBgWM2SndOOWDNtgUUko")

modules/repository/temp.go

@@ -21,7 +21,7 @@ func localCopyPath() string {
 	} else if !filepath.IsAbs(setting.Repository.Local.LocalCopyPath) {
 		return filepath.Join(setting.TempDir(), setting.Repository.Local.LocalCopyPath)
 	}
-	return filepath.Join(setting.AppDataPath, setting.Repository.Local.LocalCopyPath)
+	return setting.Repository.Local.LocalCopyPath
 }
 
 // CreateTemporaryPath creates a temporary path

modules/setting/global.go

@@ -37,7 +37,3 @@ func TempDir() string {
 	})
 	return tempDir
 }
-
-func CleanUpTempDirs() {
-	//_ = os.RemoveAll(TempDir())
-}

modules/setting/path.go

@@ -91,7 +91,6 @@ func (s *stringWithDefault) Set(v string) {
 func InitWorkPathAndCommonConfig(getEnvFn func(name string) string, args ArgWorkPathAndCustomConf) {
 	InitWorkPathAndCfgProvider(getEnvFn, args)
 	LoadCommonSettings()
-	CleanUpTempDirs()
 }
 
 // InitWorkPathAndCfgProvider will set AppWorkPath, CustomPath and CustomConf, init default config provider by CustomConf

routers/install/install.go

@@ -530,7 +530,6 @@ func SubmitInstall(ctx *context.Context) {
 	// Reload settings (and re-initialize database connection)
 	setting.InitCfgProvider(setting.CustomConf)
 	setting.LoadCommonSettings()
-	setting.CleanUpTempDirs()
 	setting.MustInstalled()
 	setting.LoadDBSetting()
 	if err := common.InitDBEngine(ctx); err != nil {