as per @lunny ... finished

Author: 6543

models/git/protected_branch.go

@@ -84,18 +84,18 @@ func IsRuleNameSpecial(ruleName string) bool {
 
 func (protectBranch *ProtectedBranch) loadGlob() {
 	if protectBranch.isPlainName || protectBranch.globRule != nil {
-	    return
-		// detect if it is not glob
-		if !IsRuleNameSpecial(protectBranch.RuleName) {
-			protectBranch.isPlainName = true
-			return
-		}
-		var err error
-		protectBranch.globRule, err = glob.Compile(protectBranch.RuleName, '/')
-		if err != nil {
-			log.Warn("Invalid glob rule for ProtectedBranch[%d]: %s %v", protectBranch.ID, protectBranch.RuleName, err)
-			protectBranch.globRule = glob.MustCompile(glob.QuoteMeta(protectBranch.RuleName), '/')
-		}
+		return
+	}
+	// detect if it is not glob
+	if !IsRuleNameSpecial(protectBranch.RuleName) {
+		protectBranch.isPlainName = true
+		return
+	}
+	var err error
+	protectBranch.globRule, err = glob.Compile(protectBranch.RuleName, '/')
+	if err != nil {
+		log.Warn("Invalid glob rule for ProtectedBranch[%d]: %s %v", protectBranch.ID, protectBranch.RuleName, err)
+		protectBranch.globRule = glob.MustCompile(glob.QuoteMeta(protectBranch.RuleName), '/')
 	}
 }