Rename functions and add some comments

Author: lunny

routers/web/repo/branch.go

@@ -47,7 +47,7 @@ func Branches(ctx *context.Context) {
 	ctx.Data["PageIsViewCode"] = true
 	ctx.Data["PageIsBranches"] = true
 
-	if !shared.RenderRepoSubMenu(ctx) {
+	if !shared.PrepareForRepoSubMenu(ctx) {
 		return
 	}
 

routers/web/repo/commit.go

@@ -62,7 +62,7 @@ func Commits(ctx *context.Context) {
 	}
 	ctx.Data["PageIsViewCode"] = true
 
-	if !shared.RenderRepoSubMenu(ctx) {
+	if !shared.PrepareForRepoSubMenu(ctx) {
 		return
 	}
 
@@ -201,7 +201,7 @@ func SearchCommits(ctx *context.Context) {
 	ctx.Data["PageIsCommits"] = true
 	ctx.Data["PageIsViewCode"] = true
 
-	if !shared.RenderRepoSubMenu(ctx) {
+	if !shared.PrepareForRepoSubMenu(ctx) {
 		return
 	}
 
@@ -233,7 +233,7 @@ func SearchCommits(ctx *context.Context) {
 
 // FileHistory show a file's reversions
 func FileHistory(ctx *context.Context) {
-	if !shared.RenderRepoSubMenu(ctx) {
+	if !shared.PrepareForRepoSubMenu(ctx) {
 		return
 	}
 

routers/web/repo/release.go

@@ -157,8 +157,9 @@ func Releases(ctx *context.Context) {
 	ctx.Data["CanCreateBranch"] = false
 	ctx.Data["HideBranchesInDropdown"] = true
 
+	// repo/release_tag_header.tmpl will render sub menu depending on the different permission
 	if !ctx.Repo.CanRead(unit.TypeReleases) && ctx.Repo.CanRead(unit.TypeCode) {
-		if !shared.RenderRepoSubMenu(ctx) {
+		if !shared.PrepareForRepoSubMenu(ctx) {
 			return
 		}
 	}
@@ -214,8 +215,9 @@ func TagsList(ctx *context.Context) {
 	ctx.Data["HideBranchesInDropdown"] = true
 	ctx.Data["CanCreateRelease"] = ctx.Repo.CanWrite(unit.TypeReleases) && !ctx.Repo.Repository.IsArchived
 
+	// repo/release_tag_header.tmpl will render sub menu depending on the different permission
 	if !ctx.Repo.CanRead(unit.TypeReleases) && ctx.Repo.CanRead(unit.TypeCode) {
-		if !shared.RenderRepoSubMenu(ctx) {
+		if !shared.PrepareForRepoSubMenu(ctx) {
 			return
 		}
 	}

routers/web/repo/shared/sub_menu.go

@@ -9,11 +9,13 @@ import (
 	repo_service "code.gitea.io/gitea/services/repository"
 )
 
-func RenderRepoSubMenu(ctx *context.Context) bool {
-	return renderLicenses(ctx)
+// PrepareForRepoSubMenu will prepare all sub menus' data for some repositories pages
+// TODO: moving prepae commits count, branches count, tags count and repository size to this function
+func PrepareForRepoSubMenu(ctx *context.Context) bool {
+	return prepareForLicenses(ctx)
 }
 
-func renderLicenses(ctx *context.Context) bool {
+func prepareForLicenses(ctx *context.Context) bool {
 	repoLicenses, err := repo_model.GetRepoLicenses(ctx, ctx.Repo.Repository)
 	if err != nil {
 		ctx.ServerError("GetRepoLicenses", err)

routers/web/repo/view.go

@@ -981,7 +981,7 @@ func renderHomeCode(ctx *context.Context) {
 		return
 	}
 
-	if !shared.RenderRepoSubMenu(ctx) {
+	if !shared.PrepareForRepoSubMenu(ctx) {
 		return
 	}