Skip to content

Commit d7179b6

Browse files
authored
Update models/actions/run_job_status_test.go
Signed-off-by: wxiaoguang <[email protected]>
1 parent 8726113 commit d7179b6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

models/actions/run_job_status_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ func TestAggregateJobStatus(t *testing.T) {
5858
{[]Status{StatusCancelled, StatusRunning}, StatusCancelled},
5959
{[]Status{StatusCancelled, StatusBlocked}, StatusCancelled},
6060

61-
// failure with other status, fail fast
61+
// failure with other status, usually fail fast, but "running" wins to match GitHub's behavior
62+
// anther reason that we can't make "failure" wins over "running": it would cause a weird behavior that user cannot cancel a workflow or get current running workflows correctly by filter after a job fail.
6263
{[]Status{StatusFailure}, StatusFailure},
6364
{[]Status{StatusFailure, StatusSuccess}, StatusFailure},
6465
{[]Status{StatusFailure, StatusSkipped}, StatusFailure},

0 commit comments

Comments
 (0)