fix test

Author: lunny

modules/git/gitcmd/command_test.go

@@ -4,11 +4,27 @@
 package gitcmd
 
 import (
+	"fmt"
+	"os"
 	"testing"
 
+	"code.gitea.io/gitea/modules/setting"
+	"code.gitea.io/gitea/modules/tempdir"
+
 	"github.com/stretchr/testify/assert"
 )
 
+func TestMain(m *testing.M) {
+	gitHomePath, cleanup, err := tempdir.OsTempDir("gitea-test").MkdirTempRandom("git-home")
+	if err != nil {
+		_, _ = fmt.Fprintf(os.Stderr, "unable to create temp dir: %v", err)
+		os.Exit(1)
+	}
+	defer cleanup()
+
+	setting.Git.HomePath = gitHomePath
+}
+
 func TestRunWithContextStd(t *testing.T) {
 	cmd := NewCommand("--version")
 	stdout, stderr, err := cmd.RunStdString(t.Context(), &RunOpts{})

modules/git/gitcmd/env.go

@@ -32,7 +32,7 @@ func HomeDir() string {
 	if setting.Git.HomePath == "" {
 		// strict check, make sure the git module is initialized correctly.
 		// attention: when the git module is called in gitea sub-command (serv/hook), the log module might not obviously show messages to users/developers.
-		// for example: if there is gitea git hook code calling cmd.NewCommand before git.InitXxx, the integration test won't show the real failure reasons.
+		// for example: if there is gitea git hook code calling NewCommand before git.InitXxx, the integration test won't show the real failure reasons.
 		log.Fatal("Unable to init Git's HomeDir, incorrect initialization of the setting and git modules")
 		return ""
 	}