Merge the update logic

Author: lunny

models/issues/comment.go

@@ -1315,16 +1315,18 @@ func (c *Comment) HasOriginalAuthor() bool {
 	return c.OriginalAuthor != "" && c.OriginalAuthorID != 0
 }
 
+func UpdateIssueNumCommentsBuilder(issueID int64) *builder.Builder {
+	subQuery := builder.Select("COUNT(*)").From("`comment`").Where(
+		builder.Eq{"issue_id": issueID}.And(
+			builder.In("`type`", ConversationCountedCommentType()),
+		))
+
+	return builder.Update(builder.Eq{"num_comments": subQuery}).
+		From("`issue`").Where(builder.Eq{"id": issueID})
+}
+
 func UpdateIssueNumComments(ctx context.Context, issueID int64) error {
-	countCommentsBuilder := builder.Select("count(*)").From("comment").Where(builder.Eq{
-		"issue_id": issueID,
-	}.And(builder.In("type", ConversationCountedCommentType())))
-
-	_, err := db.GetEngine(ctx).
-		SetExpr("num_comments", countCommentsBuilder).
-		ID(issueID).
-		NoAutoTime().
-		Update(new(Issue))
+	_, err := db.GetEngine(ctx).Exec(UpdateIssueNumCommentsBuilder(issueID))
 	return err
 }
 

models/issues/review.go

@@ -639,6 +639,10 @@ func InsertReviews(ctx context.Context, reviews []*Review) error {
 				return err
 			}
 		}
+
+		if err := UpdateIssueNumComments(ctx, review.IssueID); err != nil {
+			return err
+		}
 	}
 
 	return committer.Commit()

models/repo.go

@@ -109,14 +109,7 @@ func userStatsCorrectNumRepos(ctx context.Context, id int64) error {
 }
 
 func repoStatsCorrectIssueNumComments(ctx context.Context, id int64) error {
-	return StatsCorrectSQL(ctx,
-		builder.Update(builder.Eq{
-			"num_comments": builder.Select("COUNT(*)").From("`comment`").Where(
-				builder.Eq{"issue_id": id}.And(
-					builder.In("type", issues_model.ConversationCountedCommentType()),
-				)),
-		}).From("`issue`").Where(builder.Eq{"id": id}),
-	)
+	return StatsCorrectSQL(ctx, issues_model.UpdateIssueNumCommentsBuilder(id))
 }
 
 func repoStatsCorrectNumIssues(ctx context.Context, id int64) error {