@@ -1261,30 +1261,28 @@ func ValidateRepoMetas(ctx *context.Context, form forms.CreateIssueForm, isPull
12611261
12621262 // Check reviewers
12631263 var reviewerIDs []int64
1264- if isPull {
1265- if len (form .ReviewerIDs ) > 0 {
1266- reviewerIDs , err = base .StringsToInt64s (strings .Split (form .ReviewerIDs , "," ))
1267- if err != nil {
1268- return nil , nil , nil , 0 , 0
1269- }
1270-
1271- // Check if the passed reviewers (user/team) actually exist
1272- for _ , rID := range reviewerIDs {
1273- // negative reviewIDs represent team requests
1274- if rID < 0 {
1275- _ , err := organization .GetTeamByID (ctx , - rID )
1276- if err != nil {
1277- ctx .ServerError ("GetTeamByID" , err )
1278- return nil , nil , nil , 0 , 0
1279- }
1280- continue
1281- }
1264+ if isPull && len (form .ReviewerIDs ) > 0 {
1265+ reviewerIDs , err = base .StringsToInt64s (strings .Split (form .ReviewerIDs , "," ))
1266+ if err != nil {
1267+ return nil , nil , nil , 0 , 0
1268+ }
12821269
1283- _ , err := user_model .GetUserByID (ctx , rID )
1270+ // Check if the passed reviewers (user/team) actually exist
1271+ for _ , rID := range reviewerIDs {
1272+ // negative reviewIDs represent team requests
1273+ if rID < 0 {
1274+ _ , err := organization .GetTeamByID (ctx , - rID )
12841275 if err != nil {
1285- ctx .ServerError ("GetUserByID " , err )
1276+ ctx .ServerError ("GetTeamByID " , err )
12861277 return nil , nil , nil , 0 , 0
12871278 }
1279+ continue
1280+ }
1281+
1282+ _ , err := user_model .GetUserByID (ctx , rID )
1283+ if err != nil {
1284+ ctx .ServerError ("GetUserByID" , err )
1285+ return nil , nil , nil , 0 , 0
12881286 }
12891287 }
12901288 }
0 commit comments