fix(gitdiff): fix line number handling in FillHiddenCommentIDsForDiffLine

Author: brymut

services/gitdiff/gitdiff.go

@@ -223,16 +223,16 @@ func FillHiddenCommentIDsForDiffLine(line *DiffLine, lineComments map[int64][]*i
 
 	var hiddenCommentIDs []int64
 	for commentLineNum, comments := range lineComments {
-		absLineNum := int(commentLineNum)
-		if absLineNum < 0 {
-			absLineNum = -absLineNum
+		if commentLineNum < 0 {
+			continue // Skip left-side
 		}
+		lineNum := int(commentLineNum)
 		// Check if comments are in the hidden range
-		// depending on 'end-of-file' expansion might be RightHunkSize = 0
+		// The hidden range depends on whether this is an end-of-file expansion
 		isEndOfFileExpansion := line.SectionInfo.RightHunkSize == 0
-		inRange := absLineNum > line.SectionInfo.LastRightIdx &&
-			(isEndOfFileExpansion && absLineNum <= line.SectionInfo.RightIdx ||
-				!isEndOfFileExpansion && absLineNum < line.SectionInfo.RightIdx)
+		inRange := lineNum > line.SectionInfo.LastRightIdx &&
+			(isEndOfFileExpansion && lineNum <= line.SectionInfo.RightIdx ||
+				!isEndOfFileExpansion && lineNum < line.SectionInfo.RightIdx)
 
 		if inRange {
 			for _, comment := range comments {

services/gitdiff/gitdiff_test.go

@@ -805,9 +805,10 @@ func TestCalculateHiddenCommentIDsForLine(t *testing.T) {
 				},
 			},
 			lineComments: map[int64][]*issues_model.Comment{
-				-15: {{ID: 100}},
+				-15: {{ID: 100}}, // Left-side comment, should NOT be counted
+				15:  {{ID: 101}}, // Right-side comment, should be counted
 			},
-			expected: []int64{100},
+			expected: []int64{101}, // Only right-side comment
 		},
 		{
 			name: "boundary conditions - normal expansion (both boundaries exclusive)",