Skip to content

Commit da2180e

Browse files
committed
fix naming of htmlurl
1 parent 1684975 commit da2180e

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

modules/structs/repo_actions.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ type ActionWorkflowStep struct {
113113
type ActionWorkflowJob struct {
114114
ID int64 `json:"id"`
115115
URL string `json:"url"`
116-
HtmlURL string `json:"html_url"`
116+
HTMLURL string `json:"html_url"`
117117
RunID int64 `json:"run_id"`
118118
RunURL string `json:"run_url"`
119119
Name string `json:"name"`

services/webhook/notifier.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1004,7 +1004,7 @@ func (*webhookNotifier) WorkflowJobStatusUpdate(ctx context.Context, repo *repo_
10041004
ID: job.ID,
10051005
// missing api endpoint for this location
10061006
URL: fmt.Sprintf("%s/actions/runs/%d/jobs/%d", repo.APIURL(), job.RunID, job.ID),
1007-
HtmlURL: fmt.Sprintf("%s/jobs/%d", job.Run.HTMLURL(), jobIndex),
1007+
HTMLURL: fmt.Sprintf("%s/jobs/%d", job.Run.HTMLURL(), jobIndex),
10081008
RunID: job.RunID,
10091009
// Missing api endpoint for this location, artifacts are available under a nested url
10101010
RunURL: fmt.Sprintf("%s/actions/runs/%d", repo.APIURL(), job.RunID),

tests/integration/repo_webhook_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ jobs:
704704
assert.EqualValues(t, "user2/repo1", payloads[3].Repository.FullName)
705705
assert.Contains(t, payloads[3].WorkflowJob.URL, fmt.Sprintf("/actions/runs/%d/jobs/%d", payloads[3].WorkflowJob.RunID, payloads[3].WorkflowJob.ID))
706706
assert.Contains(t, payloads[3].WorkflowJob.URL, payloads[3].WorkflowJob.RunURL)
707-
assert.Contains(t, payloads[3].WorkflowJob.HtmlURL, fmt.Sprintf("/jobs/%d", 0))
707+
assert.Contains(t, payloads[3].WorkflowJob.HTMLURL, fmt.Sprintf("/jobs/%d", 0))
708708
assert.Len(t, payloads[3].WorkflowJob.Steps, 1)
709709

710710
assert.EqualValues(t, "queued", payloads[4].Action)
@@ -742,7 +742,7 @@ jobs:
742742
assert.EqualValues(t, "user2/repo1", payloads[6].Repository.FullName)
743743
assert.Contains(t, payloads[6].WorkflowJob.URL, fmt.Sprintf("/actions/runs/%d/jobs/%d", payloads[6].WorkflowJob.RunID, payloads[6].WorkflowJob.ID))
744744
assert.Contains(t, payloads[6].WorkflowJob.URL, payloads[6].WorkflowJob.RunURL)
745-
assert.Contains(t, payloads[6].WorkflowJob.HtmlURL, fmt.Sprintf("/jobs/%d", 1))
745+
assert.Contains(t, payloads[6].WorkflowJob.HTMLURL, fmt.Sprintf("/jobs/%d", 1))
746746
assert.Len(t, payloads[6].WorkflowJob.Steps, 2)
747747
})
748748
}

0 commit comments

Comments
 (0)