update

Author: NorthRealm

options/locale/locale_en-US.ini

@@ -3733,6 +3733,9 @@ deletion = Remove secret
 deletion.description = Removing a secret is permanent and cannot be undone. Continue?
 deletion.success = The secret has been removed.
 deletion.failed = Failed to remove secret.
+edit = Edit secret
+edit.success = The secret has been updated.
+edit.failed = Failed to update secret.
 management = Secrets Management
 
 [actions]

routers/web/shared/secrets/secrets.go

@@ -29,14 +29,19 @@ func SetSecretsContext(ctx *context.Context, ownerID, repoID int64) {
 func PerformSecretsPost(ctx *context.Context, ownerID, repoID int64, redirectURL string) {
 	form := web.GetForm(ctx).(*forms.AddSecretForm)
 
-	s, _, err := secret_service.CreateOrUpdateSecret(ctx, ownerID, repoID, form.Name, util.ReserveLineBreakForTextarea(form.Data), form.Description)
+	s, created, err := secret_service.CreateOrUpdateSecret(ctx, ownerID, repoID, form.Name, util.ReserveLineBreakForTextarea(form.Data), form.Description)
 	if err != nil {
 		log.Error("CreateOrUpdateSecret failed: %v", err)
+		// TODO: secrets.creation.failed and secrets.edit.failed?
 		ctx.JSONError(ctx.Tr("secrets.creation.failed"))
 		return
 	}
 
-	ctx.Flash.Success(ctx.Tr("secrets.creation.success", s.Name))
+	if created {
+		ctx.Flash.Success(ctx.Tr("secrets.creation.success", s.Name))
+	} else {
+		ctx.Flash.Success(ctx.Tr("secrets.edit.success", s.Name))
+	}
 	ctx.JSONRedirect(redirectURL)
 }
 

templates/shared/secrets/add_list.tmpl

@@ -33,6 +33,17 @@
 				<span class="color-text-light-2">
 					{{ctx.Locale.Tr "settings.added_on" (DateUtils.AbsoluteShort .CreatedUnix)}}
 				</span>
+				<button class="ui btn interact-bg show-modal tw-p-2"
+					data-modal="#add-secret-modal"
+					data-modal-form.action="{{$.Link}}"
+					data-modal-header="{{ctx.Locale.Tr "secrets.edit"}}"
+					data-tooltip-content="{{ctx.Locale.Tr "secrets.edit"}}"
+					data-modal-secret-name.value="{{.Name}}"
+					data-modal-secret-name.disabled="true"
+					data-modal-secret-description="{{if .Description}}{{.Description}}{{end}}"
+				>
+					{{svg "octicon-pencil"}}
+				</button>
 				<button class="ui btn interact-bg link-action tw-p-2"
 					data-url="{{$.Link}}/delete?id={{.ID}}"
 					data-modal-confirm="{{ctx.Locale.Tr "secrets.deletion.description"}}"