Apply suggestions from code review

Zettat123 · wxiaoguang · web-flow · commit dc4eb74a5d83 · 2025-06-22T09:39:35.000-06:00
Co-authored-by: wxiaoguang &lt;wxiaoguang@gmail.com&gt;
Signed-off-by: Zettat123 &lt;zettat123@gmail.com&gt;
diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go
@@ -47,9 +47,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus,
 				requiredContextMatched = true
 			}
 		}
-		if !requiredContextMatched {
-			allRequiredContextsMatched = false
-		}
+		allRequiredContextsMatched = allRequiredContextsMatched && requiredContextMatched
 	}
 	if len(requiredCommitStatuses) == 0 {
 		return commitstatus.CommitStatusPending

Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus,`
`47`	`47`	`requiredContextMatched = true`
`48`	`48`	`}`
`49`	`49`	`}`
`50`		`- if !requiredContextMatched {`
`51`		`- allRequiredContextsMatched = false`
`52`		`- }`
	`50`	`+ allRequiredContextsMatched = allRequiredContextsMatched && requiredContextMatched`
`53`	`51`	`}`
`54`	`52`	`if len(requiredCommitStatuses) == 0 {`
`55`	`53`	`return commitstatus.CommitStatusPending`