Load reviewer before sending notification (#27063)

sebastian-sauer · web-flow · commit e116ad4500bb · 2023-09-13T19:48:36.000Z
The [template](https://github.com/go-gitea/gitea/blob/main/templates/mail/issue/default.tmpl#L51) uses the Reviewer.Name property - this was not loaded. Fixes #27035
diff --git a/services/mailer/notify.go b/services/mailer/notify.go
@@ -176,6 +176,9 @@ func (m *mailNotifier) PullRequestPushCommits(ctx context.Context, doer *user_mo
 }
 
 func (m *mailNotifier) PullReviewDismiss(ctx context.Context, doer *user_model.User, review *issues_model.Review, comment *issues_model.Comment) {
+	if err := comment.Review.LoadReviewer(ctx); err != nil {
+		log.Error("Error in PullReviewDismiss while loading reviewer for issue[%d], review[%d] and reviewer[%d]: %v", review.Issue.ID, comment.Review.ID, comment.Review.ReviewerID, err)
+	}
 	if err := MailParticipantsComment(ctx, comment, activities_model.ActionPullReviewDismissed, review.Issue, nil); err != nil {
 		log.Error("MailParticipantsComment: %v", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -176,6 +176,9 @@ func (m mailNotifier) PullRequestPushCommits(ctx context.Context, doer user_mo`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`func (m mailNotifier) PullReviewDismiss(ctx context.Context, doer user_model.User, review issues_model.Review, comment issues_model.Comment) {`
	`179`	`+ if err := comment.Review.LoadReviewer(ctx); err != nil {`
	`180`	`+ log.Error("Error in PullReviewDismiss while loading reviewer for issue[%d], review[%d] and reviewer[%d]: %v", review.Issue.ID, comment.Review.ID, comment.Review.ReviewerID, err)`
	`181`	`+ }`
`179`	`182`	`if err := MailParticipantsComment(ctx, comment, activities_model.ActionPullReviewDismissed, review.Issue, nil); err != nil {`
`180`	`183`	`log.Error("MailParticipantsComment: %v", err)`
`181`	`184`	`}`