Fix bug

Author: lunny

web_src/js/components/projects/ProjectWorkflow.vue

@@ -69,26 +69,20 @@ const isInEditMode = computed(() => {
   return store.selectedWorkflow._isEditing || false;
 });
 
+// Helper to set edit mode for current workflow
+const setEditMode = (enabled: boolean) => {
+  if (store.selectedWorkflow) {
+    store.selectedWorkflow._isEditing = enabled;
+  }
+};
+
 const showCancelButton = computed(() => {
   if (!store.selectedWorkflow) return false;
   if (store.selectedWorkflow.id > 0) return true;
   const eventId = store.selectedWorkflow.event_id ?? '';
   return typeof eventId === 'string' && eventId.startsWith('clone-');
 });
 
-// Helper to set edit mode for current workflow
-const setEditMode = (enabled) => {
-  if (store.selectedWorkflow) {
-    if (enabled) {
-      store.selectedWorkflow._isEditing = true;
-    } else {
-      delete store.selectedWorkflow._isEditing;
-    }
-  }
-};
-
-// Store previous selection for cancel functionality
-
 const isTemporaryWorkflow = (workflow) => {
   if (!workflow) return false;
   if (workflow.id > 0) return false;

web_src/js/components/projects/WorkflowStore.ts

@@ -2,7 +2,7 @@ import {reactive} from 'vue';
 import {GET, POST} from '../../modules/fetch.ts';
 import {showErrorToast} from '../../modules/toast.ts';
 
-type WorkflowFiltersState = {
+type WorkflowFilters = {
   issue_type: string;
   source_column: string;
   target_column: string;
@@ -11,22 +11,22 @@ type WorkflowFiltersState = {
 
 type WorkflowIssueStateAction = '' | 'close' | 'reopen';
 
-type WorkflowActionsState = {
+type WorkflowActions = {
   column: string;
   add_labels: string[];
   remove_labels: string[];
   issue_state: WorkflowIssueStateAction;
 };
 
 type WorkflowDraftState = {
-  filters: WorkflowFiltersState;
-  actions: WorkflowActionsState;
+  filters: WorkflowFilters;
+  actions: WorkflowActions;
 };
 
-const createDefaultFilters = (): WorkflowFiltersState => ({issue_type: '', source_column: '', target_column: '', labels: []});
-const createDefaultActions = (): WorkflowActionsState => ({column: '', add_labels: [], remove_labels: [], issue_state: ''});
+const createDefaultFilters = (): WorkflowFilters => ({issue_type: '', source_column: '', target_column: '', labels: []});
+const createDefaultActions = (): WorkflowActions => ({column: '', add_labels: [], remove_labels: [], issue_state: ''});
 
-function convertFilters(workflow: any): WorkflowFiltersState {
+function convertFilters(workflow: any): WorkflowFilters {
   const filters = createDefaultFilters();
   if (workflow?.filters && Array.isArray(workflow.filters)) {
     for (const filter of workflow.filters) {
@@ -44,7 +44,7 @@ function convertFilters(workflow: any): WorkflowFiltersState {
   return filters;
 }
 
-function convertActions(workflow: any): WorkflowActionsState {
+function convertActions(workflow: any): WorkflowActions {
   const actions = createDefaultActions();
 
   if (workflow?.actions && Array.isArray(workflow.actions)) {
@@ -66,14 +66,14 @@ function convertActions(workflow: any): WorkflowActionsState {
   return actions;
 }
 
-const cloneFilters = (filters: WorkflowFiltersState): WorkflowFiltersState => ({
+const cloneFilters = (filters: WorkflowFilters): WorkflowFilters => ({
   issue_type: filters.issue_type,
   source_column: filters.source_column,
   target_column: filters.target_column,
   labels: Array.from(filters.labels),
 });
 
-const cloneActions = (actions: WorkflowActionsState): WorkflowActionsState => ({
+const cloneActions = (actions: WorkflowActions): WorkflowActions => ({
   column: actions.column,
   add_labels: Array.from(actions.add_labels),
   remove_labels: Array.from(actions.remove_labels),
@@ -101,7 +101,7 @@ export function createWorkflowStore(props: any) {
       return store.workflowDrafts[eventId];
     },
 
-    updateDraft(eventId: string, filters: WorkflowFiltersState, actions: WorkflowActionsState) {
+    updateDraft(eventId: string, filters: WorkflowFilters, actions: WorkflowActions) {
       store.workflowDrafts[eventId] = {
         filters: cloneFilters(filters),
         actions: cloneActions(actions),