Skip to content

Commit e259dae

Browse files
GiteaBotyp05327
GiteaBot
and
yp05327
authored
Add missing tabs to org projects page (#22705) (#23412)
Backport #22705 by @yp05327 Fixes #22676 Context Data `IsOrganizationMember` and `IsOrganizationOwner` is used to control the visibility of `people` and `team` tab. https://github.com/go-gitea/gitea/blob/2871ea08096cba15546f357d0ec473734ee9d8be/templates/org/menu.tmpl#L19-L40 And because of the reuse of user projects page, User Context is changed to Organization Context. But the value of `IsOrganizationMember` and `IsOrganizationOwner` are not being given. I reused func `HandleOrgAssignment` to add them to the ctx, but may have some unnecessary variables, idk whether it is ok. I found there is a missing `PageIsViewProjects` at create project page. Co-authored-by: yp05327 <[email protected]>
1 parent edb618c commit e259dae

File tree

12 files changed

+115
-63
lines changed

12 files changed

+115
-63
lines changed

‎models/organization/org.go‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,32 @@ func (org *Organization) CustomAvatarRelativePath() string {
239239
return org.Avatar
240240
}
241241

242+
// UnitPermission returns unit permission
243+
func (org *Organization) UnitPermission(ctx context.Context, doer *user_model.User, unitType unit.Type) perm.AccessMode {
244+
if doer != nil {
245+
teams, err := GetUserOrgTeams(ctx, org.ID, doer.ID)
246+
if err != nil {
247+
log.Error("GetUserOrgTeams: %v", err)
248+
return perm.AccessModeNone
249+
}
250+
251+
if err := teams.LoadUnits(ctx); err != nil {
252+
log.Error("LoadUnits: %v", err)
253+
return perm.AccessModeNone
254+
}
255+
256+
if len(teams) > 0 {
257+
return teams.UnitMaxAccess(unitType)
258+
}
259+
}
260+
261+
if org.Visibility.IsPublic() {
262+
return perm.AccessModeRead
263+
}
264+
265+
return perm.AccessModeNone
266+
}
267+
242268
// CreateOrganization creates record of a new organization.
243269
func CreateOrganization(org *Organization, owner *user_model.User) (err error) {
244270
if !owner.CanCreateOrganization() {

‎models/user/user.go‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -393,6 +393,11 @@ func (u *User) IsOrganization() bool {
393393
return u.Type == UserTypeOrganization
394394
}
395395

396+
// IsIndividual returns true if user is actually a individual user.
397+
func (u *User) IsIndividual() bool {
398+
return u.Type == UserTypeIndividual
399+
}
400+
396401
// DisplayName returns full name if it's not empty,
397402
// returns username otherwise.
398403
func (u *User) DisplayName() string {

‎modules/context/org.go‎

Lines changed: 44 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"code.gitea.io/gitea/models/perm"
1212
"code.gitea.io/gitea/models/unit"
1313
user_model "code.gitea.io/gitea/models/user"
14-
"code.gitea.io/gitea/modules/log"
1514
"code.gitea.io/gitea/modules/setting"
1615
"code.gitea.io/gitea/modules/structs"
1716
)
@@ -31,29 +30,34 @@ type Organization struct {
3130
}
3231

3332
func (org *Organization) CanWriteUnit(ctx *Context, unitType unit.Type) bool {
34-
if ctx.Doer == nil {
35-
return false
36-
}
37-
return org.UnitPermission(ctx, ctx.Doer.ID, unitType) >= perm.AccessModeWrite
33+
return org.Organization.UnitPermission(ctx, ctx.Doer, unitType) >= perm.AccessModeWrite
3834
}
3935

40-
func (org *Organization) UnitPermission(ctx *Context, doerID int64, unitType unit.Type) perm.AccessMode {
41-
if doerID > 0 {
42-
teams, err := organization.GetUserOrgTeams(ctx, org.Organization.ID, doerID)
43-
if err != nil {
44-
log.Error("GetUserOrgTeams: %v", err)
45-
return perm.AccessModeNone
46-
}
47-
if len(teams) > 0 {
48-
return teams.UnitMaxAccess(unitType)
49-
}
50-
}
36+
func (org *Organization) CanReadUnit(ctx *Context, unitType unit.Type) bool {
37+
return org.Organization.UnitPermission(ctx, ctx.Doer, unitType) >= perm.AccessModeRead
38+
}
5139

52-
if org.Organization.Visibility == structs.VisibleTypePublic {
53-
return perm.AccessModeRead
54-
}
40+
func GetOrganizationByParams(ctx *Context) {
41+
orgName := ctx.Params(":org")
42+
43+
var err error
5544

56-
return perm.AccessModeNone
45+
ctx.Org.Organization, err = organization.GetOrgByName(ctx, orgName)
46+
if err != nil {
47+
if organization.IsErrOrgNotExist(err) {
48+
redirectUserID, err := user_model.LookupUserRedirect(orgName)
49+
if err == nil {
50+
RedirectToUser(ctx, orgName, redirectUserID)
51+
} else if user_model.IsErrUserRedirectNotExist(err) {
52+
ctx.NotFound("GetUserByName", err)
53+
} else {
54+
ctx.ServerError("LookupUserRedirect", err)
55+
}
56+
} else {
57+
ctx.ServerError("GetUserByName", err)
58+
}
59+
return
60+
}
5761
}
5862

5963
// HandleOrgAssignment handles organization assignment
@@ -77,25 +81,26 @@ func HandleOrgAssignment(ctx *Context, args ...bool) {
7781
requireTeamAdmin = args[3]
7882
}
7983

80-
orgName := ctx.Params(":org")
81-
8284
var err error
83-
ctx.Org.Organization, err = organization.GetOrgByName(ctx, orgName)
84-
if err != nil {
85-
if organization.IsErrOrgNotExist(err) {
86-
redirectUserID, err := user_model.LookupUserRedirect(orgName)
87-
if err == nil {
88-
RedirectToUser(ctx, orgName, redirectUserID)
89-
} else if user_model.IsErrUserRedirectNotExist(err) {
90-
ctx.NotFound("GetUserByName", err)
91-
} else {
92-
ctx.ServerError("LookupUserRedirect", err)
85+
86+
if ctx.ContextUser == nil {
87+
// if Organization is not defined, get it from params
88+
if ctx.Org.Organization == nil {
89+
GetOrganizationByParams(ctx)
90+
if ctx.Written() {
91+
return
9392
}
94-
} else {
95-
ctx.ServerError("GetUserByName", err)
9693
}
94+
} else if ctx.ContextUser.IsOrganization() {
95+
if ctx.Org == nil {
96+
ctx.Org = &Organization{}
97+
}
98+
ctx.Org.Organization = (*organization.Organization)(ctx.ContextUser)
99+
} else {
100+
// ContextUser is an individual User
97101
return
98102
}
103+
99104
org := ctx.Org.Organization
100105

101106
// Handle Visibility
@@ -156,6 +161,7 @@ func HandleOrgAssignment(ctx *Context, args ...bool) {
156161
}
157162
ctx.Data["IsOrganizationOwner"] = ctx.Org.IsOwner
158163
ctx.Data["IsOrganizationMember"] = ctx.Org.IsMember
164+
ctx.Data["IsProjectEnabled"] = true
159165
ctx.Data["IsPackageEnabled"] = setting.Packages.Enabled
160166
ctx.Data["IsRepoIndexerEnabled"] = setting.Indexer.RepoIndexerEnabled
161167
ctx.Data["IsPublicMember"] = func(uid int64) bool {
@@ -231,6 +237,10 @@ func HandleOrgAssignment(ctx *Context, args ...bool) {
231237
return
232238
}
233239
}
240+
241+
ctx.Data["CanReadProjects"] = ctx.Org.CanReadUnit(ctx, unit.TypeProjects)
242+
ctx.Data["CanReadPackages"] = ctx.Org.CanReadUnit(ctx, unit.TypePackages)
243+
ctx.Data["CanReadCode"] = ctx.Org.CanReadUnit(ctx, unit.TypeCode)
234244
}
235245

236246
// OrgAssignment returns a middleware to handle organization assignment

‎routers/web/org/home.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,7 @@ func Home(ctx *context.Context) {
156156
pager.SetDefaultParams(ctx)
157157
pager.AddParam(ctx, "language", "Language")
158158
ctx.Data["Page"] = pager
159+
ctx.Data["ContextUser"] = ctx.ContextUser
159160

160161
ctx.HTML(http.StatusOK, tplOrgHome)
161162
}

‎routers/web/org/projects.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ func NewProject(ctx *context.Context) {
123123
ctx.Data["Title"] = ctx.Tr("repo.projects.new")
124124
ctx.Data["BoardTypes"] = project_model.GetBoardConfig()
125125
ctx.Data["CanWriteProjects"] = canWriteProjects(ctx)
126+
ctx.Data["PageIsViewProjects"] = true
126127
ctx.Data["HomeLink"] = ctx.ContextUser.HomeLink()
127128
shared_user.RenderUserHeader(ctx)
128129
ctx.HTML(http.StatusOK, tplProjectsNew)

‎routers/web/shared/user/header.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ import (
99
)
1010

1111
func RenderUserHeader(ctx *context.Context) {
12+
ctx.Data["IsProjectEnabled"] = true
13+
ctx.Data["IsPackageEnabled"] = setting.Packages.Enabled
1214
ctx.Data["IsRepoIndexerEnabled"] = setting.Indexer.RepoIndexerEnabled
1315
ctx.Data["ContextUser"] = ctx.ContextUser
1416
}

‎routers/web/user/code.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ func CodeSearch(ctx *context.Context) {
2424
return
2525
}
2626

27+
ctx.Data["IsProjectEnabled"] = true
2728
ctx.Data["IsPackageEnabled"] = setting.Packages.Enabled
2829
ctx.Data["IsRepoIndexerEnabled"] = setting.Indexer.RepoIndexerEnabled
2930
ctx.Data["Title"] = ctx.Tr("explore.code")

‎routers/web/user/profile.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,7 @@ func Profile(ctx *context.Context) {
288288
pager.AddParam(ctx, "language", "Language")
289289
}
290290
ctx.Data["Page"] = pager
291+
ctx.Data["IsProjectEnabled"] = true
291292
ctx.Data["IsPackageEnabled"] = setting.Packages.Enabled
292293
ctx.Data["IsRepoIndexerEnabled"] = setting.Indexer.RepoIndexerEnabled
293294

‎routers/web/web.go‎

Lines changed: 25 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -690,6 +690,21 @@ func RegisterRoutes(m *web.Route) {
690690
}
691691
}
692692

693+
reqUnitAccess := func(unitType unit.Type, accessMode perm.AccessMode) func(ctx *context.Context) {
694+
return func(ctx *context.Context) {
695+
if ctx.ContextUser == nil {
696+
ctx.NotFound(unitType.String(), nil)
697+
return
698+
}
699+
if ctx.ContextUser.IsOrganization() {
700+
if ctx.Org.Organization.UnitPermission(ctx, ctx.Doer, unitType) < accessMode {
701+
ctx.NotFound(unitType.String(), nil)
702+
return
703+
}
704+
}
705+
}
706+
}
707+
693708
// ***** START: Organization *****
694709
m.Group("/org", func() {
695710
m.Group("/{org}", func() {
@@ -869,8 +884,10 @@ func RegisterRoutes(m *web.Route) {
869884
}
870885

871886
m.Group("/projects", func() {
872-
m.Get("", org.Projects)
873-
m.Get("/{id}", org.ViewProject)
887+
m.Group("", func() {
888+
m.Get("", org.Projects)
889+
m.Get("/{id}", org.ViewProject)
890+
}, reqUnitAccess(unit.TypeProjects, perm.AccessModeRead))
874891
m.Group("", func() { //nolint:dupl
875892
m.Get("/new", org.NewProject)
876893
m.Post("/new", web.Bind(forms.CreateProjectForm{}), org.NewProjectPost)
@@ -890,25 +907,18 @@ func RegisterRoutes(m *web.Route) {
890907
m.Post("/move", org.MoveIssues)
891908
})
892909
})
893-
}, reqSignIn, func(ctx *context.Context) {
894-
if ctx.ContextUser == nil {
895-
ctx.NotFound("NewProject", nil)
896-
return
897-
}
898-
if ctx.ContextUser.IsOrganization() {
899-
if !ctx.Org.CanWriteUnit(ctx, unit.TypeProjects) {
900-
ctx.NotFound("NewProject", nil)
901-
return
902-
}
903-
} else if ctx.ContextUser.ID != ctx.Doer.ID {
910+
}, reqSignIn, reqUnitAccess(unit.TypeProjects, perm.AccessModeWrite), func(ctx *context.Context) {
911+
if ctx.ContextUser.IsIndividual() && ctx.ContextUser.ID != ctx.Doer.ID {
904912
ctx.NotFound("NewProject", nil)
905913
return
906914
}
907915
})
908916
}, repo.MustEnableProjects)
909917

910-
m.Get("/code", user.CodeSearch)
911-
}, context_service.UserAssignmentWeb())
918+
m.Group("", func() {
919+
m.Get("/code", user.CodeSearch)
920+
}, reqUnitAccess(unit.TypeCode, perm.AccessModeRead))
921+
}, context_service.UserAssignmentWeb(), context.OrgAssignment())
912922

913923
// ***** Release Attachment Download without Signin
914924
m.Get("/{username}/{reponame}/releases/download/{vTag}/{fileName}", ignSignIn, context.RepoAssignment, repo.MustBeNotEmpty, repo.RedirectDownload)

‎services/context/user.go‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"net/http"
99
"strings"
1010

11-
org_model "code.gitea.io/gitea/models/organization"
1211
user_model "code.gitea.io/gitea/models/user"
1312
"code.gitea.io/gitea/modules/context"
1413
)
@@ -57,14 +56,6 @@ func userAssignment(ctx *context.Context, errCb func(int, string, interface{}))
5756
} else {
5857
errCb(http.StatusInternalServerError, "GetUserByName", err)
5958
}
60-
} else {
61-
if ctx.ContextUser.IsOrganization() {
62-
if ctx.Org == nil {
63-
ctx.Org = &context.Organization{}
64-
}
65-
ctx.Org.Organization = (*org_model.Organization)(ctx.ContextUser)
66-
ctx.Data["Org"] = ctx.Org.Organization
67-
}
6859
}
6960
}
7061
}

0 commit comments

Comments
 (0)