Skip to content

Commit e30e9b3

Browse files
committed
small improvements
1 parent 3789491 commit e30e9b3

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

services/automerge/automerge.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ func handlePullRequestAutoMerge(pullID int64, sha string) {
284284
}
285285

286286
// We don't check doer's permission here because their permissions have been checked
287-
// before ids were stored to the auto_merge table
287+
// before the pull request was scheduled to auto merge
288288
perm := access_model.Permission{AccessMode: perm.AccessModeWrite}
289289

290290
if err := pull_service.CheckPullMergeable(ctx, doer, &perm, pr, pull_service.MergeCheckTypeGeneral, false); err != nil {

services/automerge/notify.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func (n *automergeNotifier) PullRequestReview(ctx context.Context, pr *issues_mo
2727
// as a missing / blocking reviews could have blocked a pending automerge let's recheck
2828
if review.Type == issues_model.ReviewTypeApprove {
2929
if err := StartPRCheckAndAutoMergeBySHA(ctx, review.CommitID, pr.BaseRepo); err != nil {
30-
log.Error("StartPullRequestAutoMergeCheckBySHA: %v", err)
30+
log.Error("StartPRCheckAndAutoMergeBySHA: %v", err)
3131
}
3232
}
3333
}

services/repository/commitstatus/commitstatus.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ func CreateCommitStatus(ctx context.Context, repo *repo_model.Repository, creato
116116

117117
if status.State.IsSuccess() {
118118
if err := automerge.StartPRCheckAndAutoMergeBySHA(ctx, sha, repo); err != nil {
119-
return fmt.Errorf("MergeScheduledPullRequest[repo_id: %d, user_id: %d, sha: %s]: %w", repo.ID, creator.ID, sha, err)
119+
return fmt.Errorf("StartPRCheckAndAutoMergeBySHA[repo_id: %d, user_id: %d, sha: %s]: %w", repo.ID, creator.ID, sha, err)
120120
}
121121
}
122122

0 commit comments

Comments
 (0)