Skip to content

Commit e5729e1

Browse files
committed
Pull Request Merge Text should exclude dismissed reviews if only official once count
1 parent 9332ff2 commit e5729e1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

models/issues/pull.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
user_model "code.gitea.io/gitea/models/user"
2121
"code.gitea.io/gitea/modules/git"
2222
"code.gitea.io/gitea/modules/log"
23+
"code.gitea.io/gitea/modules/optional"
2324
"code.gitea.io/gitea/modules/setting"
2425
"code.gitea.io/gitea/modules/timeutil"
2526
"code.gitea.io/gitea/modules/util"
@@ -379,6 +380,7 @@ func (pr *PullRequest) getReviewedByLines(ctx context.Context, writer io.Writer)
379380
Types: []ReviewType{ReviewTypeApprove},
380381
IssueID: pr.IssueID,
381382
OfficialOnly: setting.Repository.PullRequest.DefaultMergeMessageOfficialApproversOnly,
383+
Dismissed: optional.Some(false),
382384
})
383385
if err != nil {
384386
log.Error("Unable to FindReviews for PR ID %d: %v", pr.ID, err)

0 commit comments

Comments
 (0)