chore: fix the extra comment icon at the end and change the icon pointer

Author: rajesh-jonnalagadda

routers/web/repo/compare.go

@@ -957,7 +957,7 @@ func ExcerptBlob(ctx *context.Context) {
 		}
 		lineCommits := allComments[filePath]
 		for _, line := range section.Lines {
-			if line.SectionInfo != nil {
+			if line.SectionInfo != nil && line.SectionInfo.RightHunkSize > 0 {
 				start := int64(line.SectionInfo.LastRightIdx + 1)
 				end := int64(line.SectionInfo.RightIdx - 1)
 				for start <= end {

services/gitdiff/gitdiff.go

@@ -482,7 +482,7 @@ func (diff *Diff) LoadComments(ctx context.Context, issue *issues_model.Issue, c
 		if lineCommits, ok := allComments[file.Name]; ok {
 			for _, section := range file.Sections {
 				for _, line := range section.Lines {
-					if line.SectionInfo != nil {
+					if line.SectionInfo != nil && line.SectionInfo.RightHunkSize > 0 {
 						start := int64(line.SectionInfo.LastRightIdx + 1)
 						end := int64(line.SectionInfo.RightIdx - 1)
 						for start <= end {

templates/repo/diff/blob_excerpt.tmpl

@@ -8,7 +8,7 @@
 				<div class="lines-comment">
 					<div>
 						{{if $line.SectionInfo.HasComments}}
-							<button>
+							<button class="section-comment-icon">
 								{{svg "octicon-comment-discussion"}}
 							</button>
 						{{end}}
@@ -81,7 +81,7 @@
 				<div class="lines-comment">
 					<div>
 						{{if $line.SectionInfo.HasComments}}
-							<button>
+							<button class="section-comment-icon">
 								{{svg "octicon-comment-discussion"}}
 							</button>
 						{{end}}

templates/repo/diff/section_split.tmpl

@@ -22,7 +22,7 @@
 						<div class="lines-comment">
 							<div>
 								{{if $line.SectionInfo.HasComments}}
-									<button>
+									<button class="section-comment-icon">
 										{{svg "octicon-comment-discussion"}}
 									</button>
 								{{end}}

templates/repo/diff/section_unified.tmpl

@@ -18,7 +18,7 @@
 						<div class="lines-comment">
 							<div>
 								{{if $line.SectionInfo.HasComments}}
-									<button>
+									<button class="section-comment-icon">
 										{{svg "octicon-comment-discussion"}}
 									</button>
 								{{end}}

web_src/css/base.css

@@ -1148,6 +1148,10 @@ overflow-menu .ui.label {
   gap: 1px;
 }
 
+.section-comment-icon {
+  cursor: default;
+}
+
 .lines-commit .blame-info .blame-data .blame-message {
   flex-grow: 2;
   overflow: hidden;