Deduplicate stars middlewares

oops.

Author: HeCorr

routers/web/repo/repo.go

@@ -376,11 +376,7 @@ func Action(ctx *context.Context) {
 	case "watch", "unwatch":
 		ctx.Data["IsWatchingRepo"] = repo_model.IsWatching(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
 	case "star", "unstar":
-		if setting.Repository.DisableStars {
-			ctx.Data["IsStaringRepo"] = false
-		} else {
-			ctx.Data["IsStaringRepo"] = repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
-		}
+		ctx.Data["IsStaringRepo"] = repo_model.IsStaring(ctx, ctx.Doer.ID, ctx.Repo.Repository.ID)
 	}
 
 	// see the `hx-trigger="refreshUserCards ..."` comments in tmpl

routers/web/web.go

@@ -851,12 +851,6 @@ func registerRoutes(m *web.Router) {
 		}
 	}
 
-	reqStarsEnabled := func(ctx *context.Context) {
-		if setting.Repository.DisableStars {
-			ctx.Error(http.StatusForbidden, "stars are disabled")
-		}
-	}
-
 	individualPermsChecker := func(ctx *context.Context) {
 		// org permissions have been checked in context.OrgAssignment(), but individual permissions haven't been checked.
 		if ctx.ContextUser.IsIndividual() {
@@ -1609,7 +1603,7 @@ func registerRoutes(m *web.Router) {
 		m.Get("/stars", starsEnabled, repo.Stars)
 		m.Get("/watchers", repo.Watchers)
 		m.Get("/search", reqUnitCodeReader, repo.Search)
-		m.Post("/action/{action:star|unstar}", reqSignIn, reqStarsEnabled, repo.Action)
+		m.Post("/action/{action:star|unstar}", reqSignIn, starsEnabled, repo.Action)
 		m.Post("/action/{action:watch|unwatch}", reqSignIn, repo.Action)
 		m.Post("/action/{action:accept_transfer|reject_transfer}", reqSignIn, repo.Action)
 	}, optSignIn, context.RepoAssignment)