Fix tests

lunny · lunny · commit ec2cc24c4b5b · 2025-05-30T16:22:57.000-07:00
diff --git a/models/git/commit_status_test.go b/models/git/commit_status_test.go
@@ -140,7 +140,7 @@ func Test_CalcCommitStatus(t *testing.T) {
 				},
 			},
 			expected: &git_model.CommitStatus{
-				State: commitstatus.CommitStatusSuccess,
+				State: commitstatus.CommitStatusPending,
 			},
 		},
 		{
diff --git a/routers/web/repo/commit.go b/routers/web/repo/commit.go
@@ -457,6 +457,9 @@ func processGitCommits(ctx *context.Context, gitCommits []*git.Commit) ([]*git_m
 	}
 	if !ctx.Repo.CanRead(unit_model.TypeActions) {
 		for _, commit := range commits {
+			if commit.Status == nil {
+				continue
+			}
 			commit.Status.HideActionsURL(ctx)
 			git_model.CommitStatusesHideActionsURL(ctx, commit.Statuses)
 		}

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ func Test_CalcCommitStatus(t *testing.T) {`
`140`	`140`	`},`
`141`	`141`	`},`
`142`	`142`	`expected: &git_model.CommitStatus{`
`143`		`- State: commitstatus.CommitStatusSuccess,`
	`143`	`+ State: commitstatus.CommitStatusPending,`
`144`	`144`	`},`
`145`	`145`	`},`
`146`	`146`	`{`
Original file line number	Diff line number	Diff line change
`@@ -457,6 +457,9 @@ func processGitCommits(ctx context.Context, gitCommits []git.Commit) ([]*git_m`
`457`	`457`	`}`
`458`	`458`	`if !ctx.Repo.CanRead(unit_model.TypeActions) {`
`459`	`459`	`for _, commit := range commits {`
	`460`	`+ if commit.Status == nil {`
	`461`	`+ continue`
	`462`	`+ }`
`460`	`463`	`commit.Status.HideActionsURL(ctx)`
`461`	`464`	`git_model.CommitStatusesHideActionsURL(ctx, commit.Statuses)`
`462`	`465`	`}`