fix comment and method name

Author: ChristopherHX

services/actions/cleanup.go

@@ -155,8 +155,8 @@ func CleanupEphemeralRunners(ctx context.Context) error {
 	return nil
 }
 
-// CleanupEphemeralRunnersByRepoID removes all ephemeral runners that have active tasks on the given repository
-func CleanupEphemeralRunnersByRepoID(ctx context.Context, repoID int64) error {
+// CleanupEphemeralRunnersByPickedTaskRepoID removes all ephemeral runners that have active/finished tasks on the given repository
+func CleanupEphemeralRunnersByPickedTaskRepoID(ctx context.Context, repoID int64) error {
 	subQuery := builder.Select("`action_runner`.id").
 		From(builder.Select("*").From("`action_runner`"), "`action_runner`"). // mysql needs this redundant subquery
 		Join("INNER", "`action_task`", "`action_task`.`runner_id` = `action_runner`.`id`").

services/repository/delete.go

@@ -134,15 +134,11 @@ func DeleteRepositoryDirectly(ctx context.Context, doer *user_model.User, repoID
 		return err
 	}
 
-	// TODO: Deleting task records could break current ephemeral runner implementation. This is a temporary workaround suggested by ChristopherHX.
-	// Since you delete potentially the only task an ephemeral act_runner has ever run, please delete the affected runners first.
-	// one of
-	//    call cleanup ephemeral runners first
-	//    delete affected ephemeral act_runners
-	//    I would make ephemeral runners fully delete directly before formally finishing the task
-	//
-	// See also: https://github.com/go-gitea/gitea/pull/34337#issuecomment-2862222788
-	if err := actions_service.CleanupEphemeralRunnersByRepoID(ctx, repoID); err != nil {
+	// CleanupEphemeralRunnersByPickedTaskRepoID does delete ephemeral global/org/user that have started any task of this repo
+	// The cannot pick a second task hardening for ephemeral runners expect that task objects remain available until runner deletion
+	// This method will delete affected ephemeral global/org/user runners
+	// &actions_model.ActionRunner{RepoID: repoID} does only handle ephemeral repository runners
+	if err := actions_service.CleanupEphemeralRunnersByPickedTaskRepoID(ctx, repoID); err != nil {
 		return fmt.Errorf("cleanupEphemeralRunners: %w", err)
 	}