Rename Clone functions

Author: lunny

modules/gitrepo/clone.go

@@ -9,10 +9,12 @@ import (
 	"code.gitea.io/gitea/modules/git"
 )
 
-func CloneIn(ctx context.Context, dstRepo Repository, from string, opts git.CloneRepoOptions) error {
-	return git.Clone(ctx, from, repoPath(dstRepo), opts)
+// CloneExternalRepo clones an external repository to the managed repository.
+func CloneExternalRepo(ctx context.Context, dstRepo Repository, remoteURL string, opts git.CloneRepoOptions) error {
+	return git.Clone(ctx, remoteURL, repoPath(dstRepo), opts)
 }
 
-func CloneOut(ctx context.Context, fromRepo Repository, to string, opts git.CloneRepoOptions) error {
+// CloneRepoToLocal clones a managed repository to a local path.
+func CloneRepoToLocal(ctx context.Context, fromRepo Repository, to string, opts git.CloneRepoOptions) error {
 	return git.Clone(ctx, repoPath(fromRepo), to, opts)
 }

services/repository/migrate.go

@@ -28,8 +28,8 @@ import (
 )
 
 func cloneWiki(ctx context.Context, repo *repo_model.Repository, opts migration.MigrateOptions, migrateTimeout time.Duration) (string, error) {
-	wikiRemotePath := repo_module.WikiRemoteURL(ctx, opts.CloneAddr)
-	if wikiRemotePath == "" {
+	wikiRemoteURL := repo_module.WikiRemoteURL(ctx, opts.CloneAddr)
+	if wikiRemoteURL == "" {
 		return "", nil
 	}
 
@@ -44,7 +44,7 @@ func cloneWiki(ctx context.Context, repo *repo_model.Repository, opts migration.
 			log.Error("Failed to remove incomplete wiki dir %q, err: %v", storageRepo.RelativePath(), err)
 		}
 	}
-	if err := gitrepo.CloneIn(ctx, storageRepo, wikiRemotePath, git.CloneRepoOptions{
+	if err := gitrepo.CloneExternalRepo(ctx, storageRepo, wikiRemoteURL, git.CloneRepoOptions{
 		Mirror:        true,
 		Quiet:         true,
 		Timeout:       migrateTimeout,

services/wiki/wiki.go

@@ -120,7 +120,7 @@ func updateWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model
 		cloneOpts.Branch = repo.DefaultWikiBranch
 	}
 
-	if err := gitrepo.CloneOut(ctx, repo.WikiStorageRepo(), basePath, cloneOpts); err != nil {
+	if err := gitrepo.CloneRepoToLocal(ctx, repo.WikiStorageRepo(), basePath, cloneOpts); err != nil {
 		log.Error("Failed to clone repository: %s (%v)", repo.FullName(), err)
 		return fmt.Errorf("failed to clone repository: %s (%w)", repo.FullName(), err)
 	}
@@ -269,7 +269,7 @@ func DeleteWikiPage(ctx context.Context, doer *user_model.User, repo *repo_model
 	}
 	defer cleanup()
 
-	if err := gitrepo.CloneOut(ctx, repo.WikiStorageRepo(), basePath, git.CloneRepoOptions{
+	if err := gitrepo.CloneRepoToLocal(ctx, repo.WikiStorageRepo(), basePath, git.CloneRepoOptions{
 		Bare:   true,
 		Shared: true,
 		Branch: repo.DefaultWikiBranch,