only use cookie for non-signed-in user

wxiaoguang · wxiaoguang · commit f859d7ad860d · 2025-10-28T17:00:03.000+08:00
diff --git a/routers/web/misc/webtheme.go b/routers/web/misc/webtheme.go
@@ -33,9 +33,10 @@ func WebThemeList(ctx *context.Context) {
 
 func WebThemeApply(ctx *context.Context) {
 	themeName := ctx.FormString("theme")
-	middleware.SetSiteCookie(ctx.Resp, "gitea_theme", themeName, 0)
 	if ctx.Doer != nil {
 		opts := &user_service.UpdateOptions{Theme: optional.Some(themeName)}
 		_ = user_service.UpdateUser(ctx, ctx.Doer, opts)
+	} else {
+		middleware.SetSiteCookie(ctx.Resp, "gitea_theme", themeName, 0)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,10 @@ func WebThemeList(ctx *context.Context) {`
`33`	`33`
`34`	`34`	`func WebThemeApply(ctx *context.Context) {`
`35`	`35`	`themeName := ctx.FormString("theme")`
`36`		`- middleware.SetSiteCookie(ctx.Resp, "gitea_theme", themeName, 0)`
`37`	`36`	`if ctx.Doer != nil {`
`38`	`37`	`opts := &user_service.UpdateOptions{Theme: optional.Some(themeName)}`
`39`	`38`	`_ = user_service.UpdateUser(ctx, ctx.Doer, opts)`
	`39`	`+ } else {`
	`40`	`+ middleware.SetSiteCookie(ctx.Resp, "gitea_theme", themeName, 0)`
`40`	`41`	`}`
`41`	`42`	`}`