test

Author: hiifong

custom/conf/app.example.ini

@@ -1309,7 +1309,6 @@ LEVEL = Info
 ;; All available reactions users can choose on issues/prs and comments.
 ;; Values can be emoji alias (:smile:) or a unicode emoji.
 ;; For custom reactions, add a tightly cropped square image to public/assets/img/emoji/reaction_name.png
-;; Deprecated in v1.24
 ;REACTIONS = +1, -1, laugh, hooray, confused, heart, rocket, eyes
 ;;
 ;; Change the number of users that are displayed in reactions tooltip (triggered by mouse hover).
@@ -1319,7 +1318,6 @@ LEVEL = Info
 ;; Additional Emojis not defined in the utf8 standard
 ;; By default we support gitea (:gitea:), to add more copy them to public/assets/img/emoji/emoji_name.png and add it to this config.
 ;; Dont mistake it for Reactions.
-;; Deprecated in v1.24
 ;CUSTOM_EMOJIS = gitea, codeberg, gitlab, git, github, gogs
 ;;
 ;; Whether the full name of the users should be shown where possible. If the full name isn't set, the username will be used.

models/migrations/fixtures/Test_MigrateIniToDatabase/system_setting.yml

@@ -0,0 +1,24 @@
+#  type Setting struct {
+#    ID           int64              `xorm:"pk autoincr"`
+#    SettingKey   string             `xorm:"varchar(255) unique"` // key should be lowercase
+#    SettingValue string             `xorm:"text"`
+#    Version      int                `xorm:"version"`
+#    Created      timeutil.TimeStamp `xorm:"created"`
+#    Updated      timeutil.TimeStamp `xorm:"updated"`
+#  }
+-
+  id: 1
+  setting_key: revision
+  version: 1
+
+-
+  id: 2
+  setting_key: picture.enable_federated_avatar
+  setting_value: false
+  version: 1
+
+-
+  id: 3
+  setting_key: picture.disable_gravatar
+  setting_value: true
+  version: 1

models/migrations/v1_24/v315_test.go

@@ -6,17 +6,18 @@ package v1_24 //nolint
 import (
 	"testing"
 
-	"code.gitea.io/gitea/models/db"
-	"code.gitea.io/gitea/models/unittest"
+	"code.gitea.io/gitea/models/migrations/base"
 
 	"github.com/stretchr/testify/assert"
 )
 
 func Test_MigrateIniToDatabase(t *testing.T) {
-	if err := db.InitEngine(t.Context()); err != nil {
-		t.Fatal(err)
+	// Prepare and load the testing database
+	x, deferable := base.PrepareTestEnv(t, 0, new(Setting))
+	defer deferable()
+	if x == nil || t.Failed() {
+		return
 	}
-	x := unittest.GetXORMEngine()
 
 	assert.NoError(t, MigrateIniToDatabase(x))
 

modules/setting/config.go

@@ -160,7 +160,7 @@ func initDefaultConfig() {
 		UI: &UIStruct{
 			ExplorePagingNum:          config.ValueJSON[int]("ui.explore_paging_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "EXPLORE_PAGING_NUM"}).WithDefault(20),
 			SitemapPagingNum:          config.ValueJSON[int]("ui.sitemap_paging_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "SITEMAP_PAGING_NUM"}).WithDefault(20),
-			IssuePagingNum:            config.ValueJSON[int]("ui.issue_paging_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "ISSUE_PAGING_NUM"}).WithDefault(5),
+			IssuePagingNum:            config.ValueJSON[int]("ui.issue_paging_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "ISSUE_PAGING_NUM"}).WithDefault(20),
 			RepoSearchPagingNum:       config.ValueJSON[int]("ui.repo_search_paging_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "REPO_SEARCH_PAGING_NUM"}).WithDefault(20),
 			MembersPagingNum:          config.ValueJSON[int]("ui.members_paging_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "MEMBERS_PAGING_NUM"}).WithDefault(20),
 			FeedMaxCommitNum:          config.ValueJSON[int]("ui.feed_max_commit_num").WithFileConfig(config.CfgSecKey{Sec: "ui", Key: "FEED_MAX_COMMIT_NUM"}).WithDefault(20),